powerpc/sparse: make some things static
authorDaniel Axtens <dja@axtens.net>
Wed, 18 May 2016 01:16:49 +0000 (11:16 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 16 Jun 2016 12:23:11 +0000 (22:23 +1000)
This is just a smattering of things picked up by sparse that should
be made static.

Signed-off-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/crash.c
arch/powerpc/kernel/sysfs.c
arch/powerpc/platforms/powernv/idle.c
arch/powerpc/platforms/pseries/pseries_energy.c

index 3dc1fade0b281c0c7c8f9bdfc5bc91c049638f4f..888bdf198c3e8a19dae75ef64b540ed6d37918a7 100644 (file)
@@ -65,7 +65,7 @@ static int handle_fault(struct pt_regs *regs)
 #ifdef CONFIG_SMP
 
 static atomic_t cpus_in_crash;
-void crash_ipi_callback(struct pt_regs *regs)
+static void crash_ipi_callback(struct pt_regs *regs)
 {
        static cpumask_t cpus_state_saved = CPU_MASK_NONE;
 
index 692873bff3341510730de0ec7e7d8c432ded989e..c4f1d1f7bae09c42f1a39476c80519811332da9d 100644 (file)
@@ -35,7 +35,7 @@ static DEFINE_PER_CPU(struct cpu, cpu_devices);
 #ifdef CONFIG_PPC64
 
 /* Time in microseconds we delay before sleeping in the idle loop */
-DEFINE_PER_CPU(long, smt_snooze_delay) = { 100 };
+static DEFINE_PER_CPU(long, smt_snooze_delay) = { 100 };
 
 static ssize_t store_smt_snooze_delay(struct device *dev,
                                      struct device_attribute *attr,
index fcc8b6861b63e60b809618b62c39155fb359346d..92a8020f3502e409b432cec62169cdc555d66543 100644 (file)
@@ -29,7 +29,7 @@
 
 static u32 supported_cpuidle_states;
 
-int pnv_save_sprs_for_winkle(void)
+static int pnv_save_sprs_for_winkle(void)
 {
        int cpu;
        int rc;
index 92767791f93b647e11cac5ec5156a0ab7f34bd49..164a13d3998acbeaababb3d6316671a29cf75d09 100644 (file)
@@ -208,19 +208,19 @@ static ssize_t percpu_deactivate_hint_show(struct device *dev,
  *     Per-cpu value of the hint
  */
 
-struct device_attribute attr_cpu_activate_hint_list =
+static struct device_attribute attr_cpu_activate_hint_list =
                __ATTR(pseries_activate_hint_list, 0444,
                cpu_activate_hint_list_show, NULL);
 
-struct device_attribute attr_cpu_deactivate_hint_list =
+static struct device_attribute attr_cpu_deactivate_hint_list =
                __ATTR(pseries_deactivate_hint_list, 0444,
                cpu_deactivate_hint_list_show, NULL);
 
-struct device_attribute attr_percpu_activate_hint =
+static struct device_attribute attr_percpu_activate_hint =
                __ATTR(pseries_activate_hint, 0444,
                percpu_activate_hint_show, NULL);
 
-struct device_attribute attr_percpu_deactivate_hint =
+static struct device_attribute attr_percpu_deactivate_hint =
                __ATTR(pseries_deactivate_hint, 0444,
                percpu_deactivate_hint_show, NULL);