drm: Nuke connector_list locking assert
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 29 Dec 2016 20:48:27 +0000 (21:48 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 30 Dec 2016 12:35:13 +0000 (13:35 +0100)
I've forgotten to remove this when revamping the
connector_list locking.

Cc: seanpaul@chromium.org
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1483044517-5770-7-git-send-email-daniel.vetter@ffwll.ch
include/drm/drm_connector.h
include/drm/drm_crtc.h

index acb4241bff7d9acdd4c046e9b242a574452b4314..d489cc003b7eebc8740a2d6d8316e05e1cd8b754 100644 (file)
@@ -875,11 +875,7 @@ void drm_mode_put_tile_group(struct drm_device *dev,
  * deprecated. Use drm_for_each_connector_iter() instead.
  */
 #define drm_for_each_connector(connector, dev) \
-       for (assert_drm_connector_list_read_locked(&(dev)->mode_config),        \
-            connector = list_first_entry(&(dev)->mode_config.connector_list,   \
-                                         struct drm_connector, head);          \
-            &connector->head != (&(dev)->mode_config.connector_list);          \
-            connector = list_next_entry(connector, head))
+       list_for_each_entry(connector, &(dev)->mode_config.connector_list, head)
 
 /**
  * struct drm_connector_list_iter - connector_list iterator
index e9bc219504392945529ec3baf421915946a15ec6..17c9f52d6ecb3f55faeef5a86d4690dd6b85670e 100644 (file)
@@ -836,18 +836,4 @@ static inline struct drm_crtc *drm_crtc_find(struct drm_device *dev,
 #define drm_for_each_crtc(crtc, dev) \
        list_for_each_entry(crtc, &(dev)->mode_config.crtc_list, head)
 
-static inline void
-assert_drm_connector_list_read_locked(struct drm_mode_config *mode_config)
-{
-       /*
-        * The connector hotadd/remove code currently grabs both locks when
-        * updating lists. Hence readers need only hold either of them to be
-        * safe and the check amounts to
-        *
-        * WARN_ON(not_holding(A) && not_holding(B)).
-        */
-       WARN_ON(!mutex_is_locked(&mode_config->mutex) &&
-               !drm_modeset_is_locked(&mode_config->connection_mutex));
-}
-
 #endif /* __DRM_CRTC_H__ */