projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
39716c5
)
dmaengine: ti: edma: fix missed failure handling
author
Chuhong Yuan
<hslester96@gmail.com>
Mon, 18 Nov 2019 07:38:02 +0000
(15:38 +0800)
committer
Vinod Koul
<vkoul@kernel.org>
Fri, 22 Nov 2019 05:43:42 +0000
(11:13 +0530)
When devm_kcalloc fails, it forgets to call edma_free_slot.
Replace direct return with failure handler to fix it.
Fixes:
1be5336bc7ba
("dmaengine: edma: New device tree binding")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link:
https://lore.kernel.org/r/20191118073802.28424-1-hslester96@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ti/edma.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/dma/ti/edma.c
b/drivers/dma/ti/edma.c
index 0ecfc2e1d798cdeab0aafef3f2d6fc5a275bcab2..756a3c951dc72a6544087cbb67054d6e99281bd4 100644
(file)
--- a/
drivers/dma/ti/edma.c
+++ b/
drivers/dma/ti/edma.c
@@
-2424,8
+2424,10
@@
static int edma_probe(struct platform_device *pdev)
ecc->tc_list = devm_kcalloc(dev, ecc->num_tc,
sizeof(*ecc->tc_list), GFP_KERNEL);
- if (!ecc->tc_list)
- return -ENOMEM;
+ if (!ecc->tc_list) {
+ ret = -ENOMEM;
+ goto err_reg1;
+ }
for (i = 0;; i++) {
ret = of_parse_phandle_with_fixed_args(node, "ti,tptcs",