staging: ccree: simplify buf mgr using local vars
authorGilad Ben-Yossef <gilad@benyossef.com>
Thu, 9 Nov 2017 09:16:12 +0000 (09:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Nov 2017 08:20:38 +0000 (09:20 +0100)
Make the code more readable by using a local variables
for commonly use expressions in the buffer manager part
of the driver.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_buffer_mgr.c

index 2d971f244bcbdc53ffdae5478d161fe9e3640445..b3ca249b941f3037b6bcecf58a3f7100ed83418b 100644 (file)
@@ -225,16 +225,18 @@ static int cc_generate_mlli(
        mlli_p = (u32 *)mlli_params->mlli_virt_addr;
        /* go over all SG's and link it to one MLLI table */
        for (i = 0; i < sg_data->num_of_buffers; i++) {
+               union buffer_array_entry *entry = &sg_data->entry[i];
+               u32 tot_len = sg_data->total_data_len[i];
+               u32 offset = sg_data->offset[i];
+
                if (sg_data->type[i] == DMA_SGL_TYPE)
-                       rc = cc_render_sg_to_mlli(dev, sg_data->entry[i].sgl,
-                                                 sg_data->total_data_len[i],
-                                                 sg_data->offset[i],
-                                                 &total_nents, &mlli_p);
+                       rc = cc_render_sg_to_mlli(dev, entry->sgl, tot_len,
+                                                 offset, &total_nents,
+                                                 &mlli_p);
                else /*DMA_BUFF_TYPE*/
-                       rc = cc_render_buff_to_mlli(dev,
-                                                   sg_data->entry[i].buffer_dma,
-                                                   sg_data->total_data_len[i],
-                                                   &total_nents, &mlli_p);
+                       rc = cc_render_buff_to_mlli(dev, entry->buffer_dma,
+                                                   tot_len, &total_nents,
+                                                   &mlli_p);
                if (rc != 0)
                        return rc;