sched/balancing: Update comments in 'struct sg_lb_stats' and 'struct sd_lb_stats'
authorIngo Molnar <mingo@kernel.org>
Fri, 8 Mar 2024 10:59:01 +0000 (11:59 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 12 Mar 2024 10:59:59 +0000 (11:59 +0100)
- Align for readability
- Capitalize consistently

Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/20240308105901.1096078-11-mingo@kernel.org
kernel/sched/fair.c

index 40b98e43d7944f34534895372a871de4e807a1e9..116a640534b9efc1b5d3eb73ceffea1a101d4353 100644 (file)
@@ -9433,17 +9433,17 @@ static void update_blocked_averages(int cpu)
 /********** Helpers for find_busiest_group ************************/
 
 /*
- * sg_lb_stats - stats of a sched_group required for load_balancing
+ * sg_lb_stats - stats of a sched_group required for load-balancing:
  */
 struct sg_lb_stats {
-       unsigned long avg_load;                 /* Avg load across the CPUs of the group */
-       unsigned long group_load;               /* Total load over the CPUs of the group */
-       unsigned long group_capacity;
-       unsigned long group_util;               /* Total utilization over the CPUs of the group */
+       unsigned long avg_load;                 /* Avg load            over the CPUs of the group */
+       unsigned long group_load;               /* Total load          over the CPUs of the group */
+       unsigned long group_capacity;           /* Capacity            over the CPUs of the group */
+       unsigned long group_util;               /* Total utilization   over the CPUs of the group */
        unsigned long group_runnable;           /* Total runnable time over the CPUs of the group */
-       unsigned int sum_nr_running;            /* Nr of tasks running in the group */
+       unsigned int sum_nr_running;            /* Nr of all tasks running in the group */
        unsigned int sum_h_nr_running;          /* Nr of CFS tasks running in the group */
-       unsigned int idle_cpus;
+       unsigned int idle_cpus;                 /* Nr of idle CPUs         in the group */
        unsigned int group_weight;
        enum group_type group_type;
        unsigned int group_asym_packing;        /* Tasks should be moved to preferred CPU */
@@ -9456,8 +9456,7 @@ struct sg_lb_stats {
 };
 
 /*
- * sd_lb_stats - Structure to store the statistics of a sched_domain
- *              during load balancing.
+ * sd_lb_stats - stats of a sched_domain required for load-balancing:
  */
 struct sd_lb_stats {
        struct sched_group *busiest;            /* Busiest group in this sd */
@@ -9465,7 +9464,7 @@ struct sd_lb_stats {
        unsigned long total_load;               /* Total load of all groups in sd */
        unsigned long total_capacity;           /* Total capacity of all groups in sd */
        unsigned long avg_load;                 /* Average load across all groups in sd */
-       unsigned int prefer_sibling;            /* tasks should go to sibling first */
+       unsigned int prefer_sibling;            /* Tasks should go to sibling first */
 
        struct sg_lb_stats busiest_stat;        /* Statistics of the busiest group */
        struct sg_lb_stats local_stat;          /* Statistics of the local group */