hwrng: ks-sa - use dev_err_probe
authorMartin Kaiser <martin@kaiser.cx>
Thu, 24 Aug 2023 19:40:37 +0000 (21:40 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Sep 2023 10:29:45 +0000 (18:29 +0800)
Replace dev_err + return with dev_err_probe.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/ks-sa-rng.c

index 70d21bf657cefadde35e986092aa1bb164193b71..dff7b9db7044ce513808e4606db80c71425f0028 100644 (file)
@@ -228,17 +228,14 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
                syscon_regmap_lookup_by_phandle(dev->of_node,
                                                "ti,syscon-sa-cfg");
 
-       if (IS_ERR(ks_sa_rng->regmap_cfg)) {
-               dev_err(dev, "syscon_node_to_regmap failed\n");
-               return -EINVAL;
-       }
+       if (IS_ERR(ks_sa_rng->regmap_cfg))
+               return dev_err_probe(dev, -EINVAL, "syscon_node_to_regmap failed\n");
 
        pm_runtime_enable(dev);
        ret = pm_runtime_resume_and_get(dev);
        if (ret < 0) {
-               dev_err(dev, "Failed to enable SA power-domain\n");
                pm_runtime_disable(dev);
-               return ret;
+               return dev_err_probe(dev, ret, "Failed to enable SA power-domain\n");
        }
 
        return devm_hwrng_register(&pdev->dev, &ks_sa_rng->rng);