mmc: sdhci-of-k1: Fix error code in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 27 May 2025 05:55:01 +0000 (08:55 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 9 Jun 2025 13:20:01 +0000 (15:20 +0200)
If spacemit_sdhci_get_clocks() fails, then propagate the error code.
Don't return success.

Fixes: e5502d15b0f3 ("mmc: sdhci-of-k1: add support for SpacemiT K1 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Yixun Lan <dlan@gentoo.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/aDVTtQdXVtRhxOrb@stanley.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-of-k1.c

index 6880d3e9ab620dab5e5fea239cf1a78e1afe0d7c..2e5da7c5834c9e2c504169b5afbe56199b35ddb8 100644 (file)
@@ -276,7 +276,8 @@ static int spacemit_sdhci_probe(struct platform_device *pdev)
 
        host->mmc->caps |= MMC_CAP_NEED_RSP_BUSY;
 
-       if (spacemit_sdhci_get_clocks(dev, pltfm_host))
+       ret = spacemit_sdhci_get_clocks(dev, pltfm_host);
+       if (ret)
                goto err_pltfm;
 
        ret = sdhci_add_host(host);