net: phylink: use for_each_set_bit()

Use for_each_set_bit() rather than open coding the for() test_bit()
loop.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Link: https://lore.kernel.org/r/E1r4p15-00Cpxe-C7@rmk-PC.armlinux.org.uk
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index d2fa949ff1ea9eecbe26c7721a287e47396f62c7..c276f9482f787f46d55042dad920d5ddeb4ad6f8 100644 (file)
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -697,18 +697,16 @@ static int phylink_validate_mask(struct phylink *pl, unsigned long *supported,
        __ETHTOOL_DECLARE_LINK_MODE_MASK(all_s) = { 0, };
        __ETHTOOL_DECLARE_LINK_MODE_MASK(s);
        struct phylink_link_state t;
-       int intf;
+       int interface;
 
-       for (intf = 0; intf < PHY_INTERFACE_MODE_MAX; intf++) {
-               if (test_bit(intf, interfaces)) {
-                       linkmode_copy(s, supported);
+       for_each_set_bit(interface, interfaces, PHY_INTERFACE_MODE_MAX) {
+               linkmode_copy(s, supported);
 
-                       t = *state;
-                       t.interface = intf;
-                       if (!phylink_validate_mac_and_pcs(pl, s, &t)) {
-                               linkmode_or(all_s, all_s, s);
-                               linkmode_or(all_adv, all_adv, t.advertising);
-                       }
+               t = *state;
+               t.interface = interface;
+               if (!phylink_validate_mac_and_pcs(pl, s, &t)) {
+                       linkmode_or(all_s, all_s, s);
+                       linkmode_or(all_adv, all_adv, t.advertising);
                }
        }