scsi: ufs: qcom: Add sanity checks for gear/lane values during ICC scaling
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 3 Apr 2024 13:20:04 +0000 (18:50 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 8 Apr 2024 19:08:45 +0000 (15:08 -0400)
Let's add the checks to warn the user if the ICC scaling is not supported
for the gear/lane values and also fallback to the max value if that's the
case.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20240403-ufs-icc-fix-v2-2-958412a5eb45@linaro.org
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-qcom.c

index 1439c1df04813f6062f4456a039b940bbadb6582..3a91255036ddd0766c65644d824a891dde18f014 100644 (file)
@@ -687,6 +687,16 @@ static struct __ufs_qcom_bw_table ufs_qcom_get_bw_table(struct ufs_qcom_host *ho
        int gear = max_t(u32, p->gear_rx, p->gear_tx);
        int lane = max_t(u32, p->lane_rx, p->lane_tx);
 
+       if (WARN_ONCE(gear > QCOM_UFS_MAX_GEAR,
+                     "ICC scaling for UFS Gear (%d) not supported. Using Gear (%d) bandwidth\n",
+                     gear, QCOM_UFS_MAX_GEAR))
+               gear = QCOM_UFS_MAX_GEAR;
+
+       if (WARN_ONCE(lane > QCOM_UFS_MAX_LANE,
+                     "ICC scaling for UFS Lane (%d) not supported. Using Lane (%d) bandwidth\n",
+                     lane, QCOM_UFS_MAX_LANE))
+               lane = QCOM_UFS_MAX_LANE;
+
        if (ufshcd_is_hs_mode(p)) {
                if (p->hs_rate == PA_HS_MODE_B)
                        return ufs_qcom_bw_table[MODE_HS_RB][gear][lane];