scsi: aic94xx: Add missing check for dma_map_single()
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Sat, 28 Jan 2023 11:08:32 +0000 (19:08 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 9 Feb 2023 00:12:25 +0000 (19:12 -0500)
Add check for dma_map_single() and return error if it fails in order to
avoid invalid DMA address.

Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Link: https://lore.kernel.org/r/20230128110832.6792-1-jiasheng@iscas.ac.cn
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aic94xx/aic94xx_task.c

index ed119a3f6f2edba37a59cf26be3630b9dbdadcbd..7f02083001100146d6518afaa4be0cadbe965ff1 100644 (file)
@@ -50,6 +50,9 @@ static int asd_map_scatterlist(struct sas_task *task,
                dma_addr_t dma = dma_map_single(&asd_ha->pcidev->dev, p,
                                                task->total_xfer_len,
                                                task->data_dir);
+               if (dma_mapping_error(&asd_ha->pcidev->dev, dma))
+                       return -ENOMEM;
+
                sg_arr[0].bus_addr = cpu_to_le64((u64)dma);
                sg_arr[0].size = cpu_to_le32(task->total_xfer_len);
                sg_arr[0].flags |= ASD_SG_EL_LIST_EOL;