bcachefs: use attribute define helper for sysfs attribute

The sysfs attribute definition has been wrapped into macro:
rw_attribute, read_attribute and write_attribute, we can
use these helpers to uniform the attribute definition.

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/sysfs.c b/fs/bcachefs/sysfs.c
index 47ac8d5ab5626cb210fc8bcf8ea59fdb05d2c795..97733c766948a3ee60de446c1df1663bb9b75f76 100644 (file)
--- a/fs/bcachefs/sysfs.c
+++ b/fs/bcachefs/sysfs.c
@@ -211,6 +211,7 @@ BCH_PERSISTENT_COUNTERS()
 #undef x
 
 rw_attribute(discard);
+read_attribute(state);
 rw_attribute(label);
 
 read_attribute(copy_gc_wait);
@@ -235,11 +236,6 @@ write_attribute(perf_test);
        BCH_TIME_STATS()
 #undef x
 
-static struct attribute sysfs_state_rw = {
-       .name = "state",
-       .mode =  0444,
-};
-
 static size_t bch2_btree_cache_size(struct bch_fs *c)
 {
        struct btree_cache *bc = &c->btree_cache;
@@ -774,7 +770,7 @@ SHOW(bch2_dev)
                prt_char(out, '\n');
        }
 
-       if (attr == &sysfs_state_rw) {
+       if (attr == &sysfs_state) {
                prt_string_option(out, bch2_member_states, ca->mi.state);
                prt_char(out, '\n');
        }
@@ -854,7 +850,7 @@ struct attribute *bch2_dev_files[] = {
 
        /* settings: */
        &sysfs_discard,
-       &sysfs_state_rw,
+       &sysfs_state,
        &sysfs_label,
 
        &sysfs_has_data,