selftests: mptcp: sockopt: fix C23 extension warning
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Fri, 15 Aug 2025 17:28:26 +0000 (19:28 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 19 Aug 2025 00:39:59 +0000 (17:39 -0700)
GCC was complaining about the new label:

  mptcp_inq.c:79:2: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     79 |         int err = getaddrinfo(node, service, hints, res);
        |         ^

  mptcp_sockopt.c:166:2: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
    166 |         int err = getaddrinfo(node, service, hints, res);
        |         ^

Simply declare 'err' before the label to avoid this warning.

Fixes: dd367e81b79a ("selftests: mptcp: sockopt: use IPPROTO_MPTCP for getaddrinfo")
Cc: stable@vger.kernel.org
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250815-net-mptcp-misc-fixes-6-17-rc2-v1-8-521fe9957892@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_inq.c
tools/testing/selftests/net/mptcp/mptcp_sockopt.c

index 3cf1e2a612cef911028f46569563d16dd5d32129..f3bcaa48df8f22e8f4833fcc3b919d21764bf7fb 100644 (file)
@@ -75,9 +75,10 @@ static void xgetaddrinfo(const char *node, const char *service,
                         struct addrinfo *hints,
                         struct addrinfo **res)
 {
-again:
-       int err = getaddrinfo(node, service, hints, res);
+       int err;
 
+again:
+       err = getaddrinfo(node, service, hints, res);
        if (err) {
                const char *errstr;
 
index 9934a68df23708ecb413c4ab26523989e3b9f158..e934dd26a59d9b50445d61e8b8013ce3c8d2a8a0 100644 (file)
@@ -162,9 +162,10 @@ static void xgetaddrinfo(const char *node, const char *service,
                         struct addrinfo *hints,
                         struct addrinfo **res)
 {
-again:
-       int err = getaddrinfo(node, service, hints, res);
+       int err;
 
+again:
+       err = getaddrinfo(node, service, hints, res);
        if (err) {
                const char *errstr;