usb: renesas_usbhs: cleanup with list_first_entry_or_null()
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Sun, 18 Sep 2016 16:03:15 +0000 (01:03 +0900)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Thu, 3 Nov 2016 08:38:37 +0000 (10:38 +0200)
The combo of list_empty() check and return list_first_entry()
can be replaced with list_first_entry_or_null().

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/renesas_usbhs/fifo.c

index 857e78337324b6488a77d8310da1a32c615e9349..d1af831f43ebad07e86e1d62b0730eb0579ebb4c 100644 (file)
@@ -100,10 +100,7 @@ static void __usbhsf_pkt_del(struct usbhs_pkt *pkt)
 
 static struct usbhs_pkt *__usbhsf_pkt_get(struct usbhs_pipe *pipe)
 {
-       if (list_empty(&pipe->list))
-               return NULL;
-
-       return list_first_entry(&pipe->list, struct usbhs_pkt, node);
+       return list_first_entry_or_null(&pipe->list, struct usbhs_pkt, node);
 }
 
 static void usbhsf_fifo_clear(struct usbhs_pipe *pipe,