spi: spi-zynq: Do not check for 0 return after calling platform_get_irq()
authorRuan Jinjie <ruanjinjie@huawei.com>
Wed, 2 Aug 2023 09:43:57 +0000 (17:43 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 7 Aug 2023 13:38:39 +0000 (14:38 +0100)
It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230802094357.981100-1-ruanjinjie@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-zynq-qspi.c
drivers/spi/spi-zynqmp-gqspi.c

index ee1995b912878103ff8c87781755eeaf8fbeb5a9..0db69a2a72ffcb9e36dd30698c47119a6c296451 100644 (file)
@@ -679,8 +679,8 @@ static int zynq_qspi_probe(struct platform_device *pdev)
        }
 
        xqspi->irq = platform_get_irq(pdev, 0);
-       if (xqspi->irq <= 0) {
-               ret = -ENXIO;
+       if (xqspi->irq < 0) {
+               ret = xqspi->irq;
                goto clk_dis_all;
        }
        ret = devm_request_irq(&pdev->dev, xqspi->irq, zynq_qspi_irq,
index a6b892d01038b5cacb8b0a389aa66f4f0d70f62b..94d9a33d9af56e8c76bf7b14937d97bec190a3a9 100644 (file)
@@ -1293,8 +1293,8 @@ static int zynqmp_qspi_probe(struct platform_device *pdev)
        zynqmp_qspi_init_hw(xqspi);
 
        xqspi->irq = platform_get_irq(pdev, 0);
-       if (xqspi->irq <= 0) {
-               ret = -ENXIO;
+       if (xqspi->irq < 0) {
+               ret = xqspi->irq;
                goto clk_dis_all;
        }
        ret = devm_request_irq(&pdev->dev, xqspi->irq, zynqmp_qspi_irq,