drm/bridge: tc358767: Only print GPIO debug output if they actually occur
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Wed, 4 Sep 2024 12:05:44 +0000 (14:05 +0200)
committerNeil Armstrong <neil.armstrong@linaro.org>
Fri, 13 Sep 2024 08:10:16 +0000 (10:10 +0200)
Currently the output the following output is printed upon each interrupt:
 tc358767 1-000f: GPIO0:
This spams the kernel log while debugging an IRQ storm from the bridge.
Only print the debug output if the GPIO hotplug event actually happened.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Link: https://lore.kernel.org/r/20240904120546.1845856-3-alexander.stein@ew.tq-group.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240904120546.1845856-3-alexander.stein@ew.tq-group.com
drivers/gpu/drm/bridge/tc358767.c

index 5ef33ce33dcaa4d125d1c7bab6e72b118b1819f7..1c42c8c6e632e86b3b6c3ae147b866e5c80e0301 100644 (file)
@@ -2229,11 +2229,11 @@ static irqreturn_t tc_irq_handler(int irq, void *arg)
                bool h = val & INT_GPIO_H(tc->hpd_pin);
                bool lc = val & INT_GPIO_LC(tc->hpd_pin);
 
-               dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin,
-                       h ? "H" : "", lc ? "LC" : "");
-
-               if (h || lc)
+               if (h || lc) {
+                       dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin,
+                               h ? "H" : "", lc ? "LC" : "");
                        drm_kms_helper_hotplug_event(tc->bridge.dev);
+               }
        }
 
        regmap_write(tc->regmap, INTSTS_G, val);