rtlwifi: rtl8192de: Fix missing callback that tests for hw release of buffer
authorLarry Finger <Larry.Finger@lwfinger.net>
Mon, 11 Nov 2019 19:40:45 +0000 (13:40 -0600)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 14 Nov 2019 15:10:15 +0000 (17:10 +0200)
In commit 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for
new drivers"), a callback needed to check if the hardware has released
a buffer indicating that a DMA operation is completed was not added.

Fixes: 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for new drivers")
Cc: Stable <stable@vger.kernel.org> # v3.18+
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.h

index 99e5cd9a5c86b8da4580ef04cbad7f978909bc0c..1dbdddce08233c16ba8cdb9e69e08fb7268a6647 100644 (file)
@@ -216,6 +216,7 @@ static struct rtl_hal_ops rtl8192de_hal_ops = {
        .led_control = rtl92de_led_control,
        .set_desc = rtl92de_set_desc,
        .get_desc = rtl92de_get_desc,
+       .is_tx_desc_closed = rtl92de_is_tx_desc_closed,
        .tx_polling = rtl92de_tx_polling,
        .enable_hw_sec = rtl92de_enable_hw_security_config,
        .set_key = rtl92de_set_key,
index b4561923a70afef995ec8ba62946eb4dcccec18a..92c9fb45f800447d70a6cdc887d10044a16ddbbc 100644 (file)
@@ -823,6 +823,23 @@ u64 rtl92de_get_desc(struct ieee80211_hw *hw,
        return ret;
 }
 
+bool rtl92de_is_tx_desc_closed(struct ieee80211_hw *hw,
+                              u8 hw_queue, u16 index)
+{
+       struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+       struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue];
+       u8 *entry = (u8 *)(&ring->desc[ring->idx]);
+       u8 own = (u8)rtl92de_get_desc(hw, entry, true, HW_DESC_OWN);
+
+       /* a beacon packet will only use the first
+        * descriptor by defaut, and the own bit may not
+        * be cleared by the hardware
+        */
+       if (own)
+               return false;
+       return true;
+}
+
 void rtl92de_tx_polling(struct ieee80211_hw *hw, u8 hw_queue)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
index 36820070fd76febb871b3848d74bc243c00852f6..635989e152828299d87284ce21ce13e7e5efb549 100644 (file)
@@ -715,6 +715,8 @@ void rtl92de_set_desc(struct ieee80211_hw *hw, u8 *pdesc, bool istx,
                      u8 desc_name, u8 *val);
 u64 rtl92de_get_desc(struct ieee80211_hw *hw,
                     u8 *p_desc, bool istx, u8 desc_name);
+bool rtl92de_is_tx_desc_closed(struct ieee80211_hw *hw,
+                              u8 hw_queue, u16 index);
 void rtl92de_tx_polling(struct ieee80211_hw *hw, u8 hw_queue);
 void rtl92de_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,
                             bool b_firstseg, bool b_lastseg,