bcachefs: Drop redundant "read error" call from btree_gc
authorKent Overstreet <kent.overstreet@linux.dev>
Sun, 15 Dec 2024 07:03:11 +0000 (02:03 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Fri, 10 Jan 2025 04:38:41 +0000 (23:38 -0500)
The btree node read error path already calls topology error, so this is
entirely redundant, and we're not specific enough about our error codes
- this was triggering for bucket_ref_update() errors.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_gc.c

index 5aa11ca08c9439681088b7491e756947b10718db..721dca55172028341217511fe395e6de0b729274 100644 (file)
@@ -733,16 +733,8 @@ static int bch2_gc_btrees(struct bch_fs *c)
                        continue;
 
                ret = bch2_gc_btree(trans, btree, true);
-
-               if (mustfix_fsck_err_on(bch2_err_matches(ret, EIO),
-                                       trans, btree_node_read_error,
-                              "btree node read error for %s",
-                              (printbuf_reset(&buf),
-                               bch2_btree_id_to_text(&buf, btree),
-                               buf.buf)))
-                       ret = bch2_btree_lost_data(c, btree);
        }
-fsck_err:
+
        printbuf_exit(&buf);
        bch2_trans_put(trans);
        bch_err_fn(c, ret);