net: sched: delete duplicate cleanup of backlog and qlen

[ Upstream commit c19d893fbf3f2f8fa864ae39652c7fee939edde2 ]

qdisc_reset() is clearing qdisc->q.qlen and qdisc->qstats.backlog
_after_ calling qdisc->ops->reset. There is no need to clear them
again in the specific reset function.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20220824005231.345727-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Stable-dep-of: 2a3fc78210b9 ("net: sched: sfb: fix null pointer access issue when sfb_init() fails")
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index bed2387af456d1b6c73a25f660671fa0a104ed8a..e7e8c318925deed09a574d558b95b5ff42d02be8 100644 (file)
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -1178,7 +1178,6 @@ static inline void __qdisc_reset_queue(struct qdisc_skb_head *qh)
 static inline void qdisc_reset_queue(struct Qdisc *sch)
 {
        __qdisc_reset_queue(&sch->q);
-       sch->qstats.backlog = 0;
 }
 
 static inline struct Qdisc *qdisc_replace(struct Qdisc *sch, struct Qdisc *new,

diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
index 1c281cc81f57789b787c77622cc2c026414f9c9d..794c7377cd7e908eba4cb41c4c184ae2c64526a5 100644 (file)
--- a/net/sched/sch_atm.c
+++ b/net/sched/sch_atm.c
@@ -575,7 +575,6 @@ static void atm_tc_reset(struct Qdisc *sch)
        pr_debug("atm_tc_reset(sch %p,[qdisc %p])\n", sch, p);
        list_for_each_entry(flow, &p->flows, list)
                qdisc_reset(flow->q);
-       sch->q.qlen = 0;
 }
 
 static void atm_tc_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c
index 4a78fcf5d4f989a78f2ced9301e9bcd15232d7e2..9a3dff02b7a2bac9fc475ee4ff828ab739c79086 100644 (file)
--- a/net/sched/sch_cbq.c
+++ b/net/sched/sch_cbq.c
@@ -1053,7 +1053,6 @@ cbq_reset(struct Qdisc *sch)
                        cl->cpriority = cl->priority;
                }
        }
-       sch->q.qlen = 0;
 }
 
 

diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c
index 2adbd945bf15aee182bc1505ec54b9695d104d52..25d2daaa81227478f3f91c57c26ea8185c686462 100644 (file)
--- a/net/sched/sch_choke.c
+++ b/net/sched/sch_choke.c
@@ -315,8 +315,6 @@ static void choke_reset(struct Qdisc *sch)
                rtnl_qdisc_drop(skb, sch);
        }
 
-       sch->q.qlen = 0;
-       sch->qstats.backlog = 0;
        if (q->tab)
                memset(q->tab, 0, (q->tab_mask + 1) * sizeof(struct sk_buff *));
        q->head = q->tail = 0;

diff --git a/net/sched/sch_drr.c b/net/sched/sch_drr.c
index dde564670ad8ca17128e45401b369144df9231a3..08424aac6da82eee4258b51d2a4686b5f007b536 100644 (file)
--- a/net/sched/sch_drr.c
+++ b/net/sched/sch_drr.c
@@ -443,8 +443,6 @@ static void drr_reset_qdisc(struct Qdisc *sch)
                        qdisc_reset(cl->qdisc);
                }
        }
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void drr_destroy_qdisc(struct Qdisc *sch)

diff --git a/net/sched/sch_dsmark.c b/net/sched/sch_dsmark.c
index 76ed1a05ded27cfc2f5f5af8581737f0abcb8498..a75bc7f80cd7e26e24646d76aa569fab455702b3 100644 (file)
--- a/net/sched/sch_dsmark.c
+++ b/net/sched/sch_dsmark.c
@@ -408,8 +408,6 @@ static void dsmark_reset(struct Qdisc *sch)
        pr_debug("%s(sch %p,[qdisc %p])\n", __func__, sch, p);
        if (p->q)
                qdisc_reset(p->q);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void dsmark_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c
index c48f91075b5c60ee4fe9e10186c913baf5894a69..d96103b0e2bf516bb668aa4037cbf85a7c8f9e30 100644 (file)
--- a/net/sched/sch_etf.c
+++ b/net/sched/sch_etf.c
@@ -445,9 +445,6 @@ static void etf_reset(struct Qdisc *sch)
        timesortedlist_clear(sch);
        __qdisc_reset_queue(&sch->q);
 
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
-
        q->last = 0;
 }
 

diff --git a/net/sched/sch_ets.c b/net/sched/sch_ets.c
index 9c224872ef0355e2b4d128c1924cb242106e31c0..05817c55692f0a2db4d027b6d6510ca6dc8edd18 100644 (file)
--- a/net/sched/sch_ets.c
+++ b/net/sched/sch_ets.c
@@ -722,8 +722,6 @@ static void ets_qdisc_reset(struct Qdisc *sch)
        }
        for (band = 0; band < q->nbands; band++)
                qdisc_reset(q->classes[band].qdisc);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void ets_qdisc_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
index 99e8db2621984903af8104ca0082d262e5f372b7..01d6eea5b0ce9695706b5f3b1164bd951db704af 100644 (file)
--- a/net/sched/sch_fq_codel.c
+++ b/net/sched/sch_fq_codel.c
@@ -347,8 +347,6 @@ static void fq_codel_reset(struct Qdisc *sch)
                codel_vars_init(&flow->cvars);
        }
        memset(q->backlogs, 0, q->flows_cnt * sizeof(u32));
-       sch->q.qlen = 0;
-       sch->qstats.backlog = 0;
        q->memory_usage = 0;
 }
 

diff --git a/net/sched/sch_fq_pie.c b/net/sched/sch_fq_pie.c
index c70802785518f4b33cbee68bbde563af60226f8c..cf04f70e96bf1fd38471d06321b97b74aef1628f 100644 (file)
--- a/net/sched/sch_fq_pie.c
+++ b/net/sched/sch_fq_pie.c
@@ -521,9 +521,6 @@ static void fq_pie_reset(struct Qdisc *sch)
                INIT_LIST_HEAD(&flow->flowchain);
                pie_vars_init(&flow->vars);
        }
-
-       sch->q.qlen = 0;
-       sch->qstats.backlog = 0;
 }
 
 static void fq_pie_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index d1902fca98447f0073e98947ae0cc7f969728022..cdc43a06aa9bccee969adc31a1bad4dbbeb7ff05 100644 (file)
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -1484,8 +1484,6 @@ hfsc_reset_qdisc(struct Qdisc *sch)
        }
        q->eligible = RB_ROOT;
        qdisc_watchdog_cancel(&q->watchdog);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void

diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index cd70dbcbd72fdddcda75d98d918f70554af60214..c3ba018fd083ea61eaebb46b782d3756e0878795 100644 (file)
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -966,8 +966,6 @@ static void htb_reset(struct Qdisc *sch)
        }
        qdisc_watchdog_cancel(&q->watchdog);
        __qdisc_reset_queue(&q->direct_queue);
-       sch->q.qlen = 0;
-       sch->qstats.backlog = 0;
        memset(q->hlevel, 0, sizeof(q->hlevel));
        memset(q->row_mask, 0, sizeof(q->row_mask));
 }

diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c
index 5c27b4270b90894dcfdd5c9621a0db8cf13582c3..1c6dbcfa89b877aeb2aae586b3d429439524ba14 100644 (file)
--- a/net/sched/sch_multiq.c
+++ b/net/sched/sch_multiq.c
@@ -152,7 +152,6 @@ multiq_reset(struct Qdisc *sch)
 
        for (band = 0; band < q->bands; band++)
                qdisc_reset(q->queues[band]);
-       sch->q.qlen = 0;
        q->curband = 0;
 }
 

diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c
index 3eabb871a1d522ad72b903ad43666ce801220c2d..1c805fe05b82a674d665711fde1f8f63d5ab11cf 100644 (file)
--- a/net/sched/sch_prio.c
+++ b/net/sched/sch_prio.c
@@ -135,8 +135,6 @@ prio_reset(struct Qdisc *sch)
 
        for (prio = 0; prio < q->bands; prio++)
                qdisc_reset(q->queues[prio]);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static int prio_offload(struct Qdisc *sch, struct tc_prio_qopt *qopt)

diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index af8c63a9ec18c53cdca0ac0bee6ff97af58996ec..1d1d81aeb389f495f1cae1c91284db881cd79d6f 100644 (file)
--- a/net/sched/sch_qfq.c
+++ b/net/sched/sch_qfq.c
@@ -1458,8 +1458,6 @@ static void qfq_reset_qdisc(struct Qdisc *sch)
                        qdisc_reset(cl->qdisc);
                }
        }
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void qfq_destroy_qdisc(struct Qdisc *sch)

diff --git a/net/sched/sch_red.c b/net/sched/sch_red.c
index 40adf1f07a82dfdb8f704eecfa9a14f000213a91..f1e013e3f04a985eeb48165edf2ff41878accdf5 100644 (file)
--- a/net/sched/sch_red.c
+++ b/net/sched/sch_red.c
@@ -176,8 +176,6 @@ static void red_reset(struct Qdisc *sch)
        struct red_sched_data *q = qdisc_priv(sch);
 
        qdisc_reset(q->qdisc);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
        red_restart(&q->vars);
 }
 

diff --git a/net/sched/sch_sfb.c b/net/sched/sch_sfb.c
index b2724057629f696f4f89032e12be07ece13549a8..0e1cb517b0d948a883e6e247ae0b686d499cb61e 100644 (file)
--- a/net/sched/sch_sfb.c
+++ b/net/sched/sch_sfb.c
@@ -456,8 +456,6 @@ static void sfb_reset(struct Qdisc *sch)
        struct sfb_sched_data *q = qdisc_priv(sch);
 
        qdisc_reset(q->qdisc);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
        q->slot = 0;
        q->double_buffering = false;
        sfb_zero_all_buckets(q);

diff --git a/net/sched/sch_skbprio.c b/net/sched/sch_skbprio.c
index 7a5e4c454715617cb57c6db7de7fdaa9e6886d40..df72fb83d9c7d88bb93d08c9a7453abe8a055eb0 100644 (file)
--- a/net/sched/sch_skbprio.c
+++ b/net/sched/sch_skbprio.c
@@ -213,9 +213,6 @@ static void skbprio_reset(struct Qdisc *sch)
        struct skbprio_sched_data *q = qdisc_priv(sch);
        int prio;
 
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
-
        for (prio = 0; prio < SKBPRIO_MAX_PRIORITY; prio++)
                __skb_queue_purge(&q->qdiscs[prio]);
 

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index ab8835a72cee6d3c8ad66dd7859ed054448a27ca..7f33b31c7b8bde4ffae185c8b9230e3b158e9189 100644 (file)
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1626,8 +1626,6 @@ static void taprio_reset(struct Qdisc *sch)
                        if (q->qdiscs[i])
                                qdisc_reset(q->qdiscs[i]);
        }
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void taprio_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
index 6eb17004a9e44c616b7ad94df832b9487380d3a6..7461e5c67d50a70164ac49e7beb458b0b77121bf 100644 (file)
--- a/net/sched/sch_tbf.c
+++ b/net/sched/sch_tbf.c
@@ -316,8 +316,6 @@ static void tbf_reset(struct Qdisc *sch)
        struct tbf_sched_data *q = qdisc_priv(sch);
 
        qdisc_reset(q->qdisc);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
        q->t_c = ktime_get_ns();
        q->tokens = q->buffer;
        q->ptokens = q->mtu;

diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c
index 6af6b95bdb6723a3d600c1defae08fd897c7a308..79aaab51cbf5c8357f282d6d4d9ba464e83e7f30 100644 (file)
--- a/net/sched/sch_teql.c
+++ b/net/sched/sch_teql.c
@@ -124,7 +124,6 @@ teql_reset(struct Qdisc *sch)
        struct teql_sched_data *dat = qdisc_priv(sch);
 
        skb_queue_purge(&dat->q);
-       sch->q.qlen = 0;
 }
 
 static void