maple_tree: break on convergence in mas_spanning_rebalance()
authorSidhartha Kumar <sidhartha.kumar@oracle.com>
Thu, 10 Apr 2025 19:14:44 +0000 (19:14 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 May 2025 00:48:28 +0000 (17:48 -0700)
This allows support for using the vacant height to calculate the worst
case number of nodes needed for wr_rebalance operation.
mas_spanning_rebalance() was seen to perform unnecessary node allocations.
We can reduce allocations by breaking early during the rebalancing loop
once we realize that we have ascended to a common ancestor.

Link: https://lkml.kernel.org/r/20250410191446.2474640-5-sidhartha.kumar@oracle.com
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Suggested-by: Liam Howlett <liam.howlett@oracle.com>
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/maple_tree.c

index 3f794ef072f470ab36960bd4e3af1580595fd9f4..5610b3742a794094717c3100311e73bc265915af 100644 (file)
@@ -2893,11 +2893,21 @@ static void mas_spanning_rebalance(struct ma_state *mas,
                mast_combine_cp_right(mast);
                mast->orig_l->last = mast->orig_l->max;
 
-               if (mast_sufficient(mast))
-                       continue;
+               if (mast_sufficient(mast)) {
+                       if (mast_overflow(mast))
+                               continue;
+
+                       if (mast->orig_l->node == mast->orig_r->node) {
+                              /*
+                               * The data in b_node should be stored in one
+                               * node and in the tree
+                               */
+                               slot = mast->l->offset;
+                               break;
+                       }
 
-               if (mast_overflow(mast))
                        continue;
+               }
 
                /* May be a new root stored in mast->bn */
                if (mas_is_root_limits(mast->orig_l))