powerpc/powermac: Fix build error seen with powermac smp builds
authorGuenter Roeck <linux@roeck-us.net>
Tue, 14 Apr 2015 19:52:50 +0000 (12:52 -0700)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 15 Apr 2015 05:52:59 +0000 (15:52 +1000)
powermac smp builds fail with

arch/powerpc/platforms/powermac/smp.c: In function 'smp_psurge_probe':
arch/powerpc/platforms/powermac/smp.c:278:3: error:
'return' with a value, in function returning void

There are several instances of this error.

Fixes: a7f4ee1fe93a ("powerpc: Drop return value of smp_ops->probe()")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/powermac/smp.c

index f84ac7ee11070909d9cec9fe82f97c77aa63cd01..28a147ca32ba0e02d52b12343da8b365bd9287a4 100644 (file)
@@ -275,7 +275,7 @@ static void __init smp_psurge_probe(void)
 
        /* We don't do SMP on the PPC601 -- paulus */
        if (PVR_VER(mfspr(SPRN_PVR)) == 1)
-               return 1;
+               return;
 
        /*
         * The powersurge cpu board can be used in the generation
@@ -289,7 +289,7 @@ static void __init smp_psurge_probe(void)
         */
        dn = of_find_node_by_name(NULL, "hammerhead");
        if (dn == NULL)
-               return 1;
+               return;
        of_node_put(dn);
 
        hhead_base = ioremap(HAMMERHEAD_BASE, 0x800);
@@ -310,13 +310,13 @@ static void __init smp_psurge_probe(void)
                        /* not a dual-cpu card */
                        iounmap(hhead_base);
                        psurge_type = PSURGE_NONE;
-                       return 1;
+                       return;
                }
                ncpus = 2;
        }
 
        if (psurge_secondary_ipi_init())
-               return 1;
+               return;
 
        psurge_start = ioremap(PSURGE_START, 4);
        psurge_pri_intr = ioremap(PSURGE_PRI_INTR, 4);
@@ -332,8 +332,6 @@ static void __init smp_psurge_probe(void)
                set_cpu_present(i, true);
 
        if (ppc_md.progress) ppc_md.progress("smp_psurge_probe - done", 0x352);
-
-       return ncpus;
 }
 
 static int __init smp_psurge_kick_cpu(int nr)