net: use eth_hw_addr_set()
authorJakub Kicinski <kuba@kernel.org>
Fri, 1 Oct 2021 21:32:19 +0000 (14:32 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 Oct 2021 13:18:25 +0000 (14:18 +0100)
Convert sw drivers from memcpy(... ETH_ADDR) to eth_hw_addr_set():

  @@
  expression dev, np;
  @@
  - memcpy(dev->dev_addr, np, ETH_ALEN)
  + eth_hw_addr_set(dev, np)

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hyperv/netvsc_drv.c
drivers/net/ipvlan/ipvlan_main.c
drivers/net/macvlan.c
net/bridge/br_stp_if.c

index 382bebc2420dfff7a5ab84a97554fd1379c15a59..479d2835a22019afcbbb15bda6d2052643e17405 100644 (file)
@@ -2536,7 +2536,7 @@ static int netvsc_probe(struct hv_device *dev,
                goto rndis_failed;
        }
 
-       memcpy(net->dev_addr, device_info->mac_adr, ETH_ALEN);
+       eth_hw_addr_set(net, device_info->mac_adr);
 
        /* We must get rtnl lock before scheduling nvdev->subchan_work,
         * otherwise netvsc_subchan_work() can get rtnl lock first and wait
index c0b21a5580d522c16f1a9f5af913bfc21271078c..cca4a00f1c518b10b11a98701e8c30507389e86c 100644 (file)
@@ -579,7 +579,7 @@ int ipvlan_link_new(struct net *src_net, struct net_device *dev,
         * world but keep using the physical-dev address for the outgoing
         * packets.
         */
-       memcpy(dev->dev_addr, phy_dev->dev_addr, ETH_ALEN);
+       eth_hw_addr_set(dev, phy_dev->dev_addr);
 
        dev->priv_flags |= IFF_NO_RX_HANDLER;
 
index 35f46ad040b0d4743976ed1b595291c243f7eddb..63563edfd4a6862c6d346feb8d1124eb302156ec 100644 (file)
@@ -202,7 +202,7 @@ static void macvlan_hash_change_addr(struct macvlan_dev *vlan,
        /* Now that we are unhashed it is safe to change the device
         * address without confusing packet delivery.
         */
-       memcpy(vlan->dev->dev_addr, addr, ETH_ALEN);
+       eth_hw_addr_set(vlan->dev, addr);
        macvlan_hash_add(vlan);
 }
 
index ba55851fe132c88bfefb90fdbd8334f97793242c..75204d36d7f9062306dfc66c3c35448e16257215 100644 (file)
@@ -233,7 +233,7 @@ void br_stp_change_bridge_id(struct net_bridge *br, const unsigned char *addr)
 
        memcpy(oldaddr, br->bridge_id.addr, ETH_ALEN);
        memcpy(br->bridge_id.addr, addr, ETH_ALEN);
-       memcpy(br->dev->dev_addr, addr, ETH_ALEN);
+       eth_hw_addr_set(br->dev, addr);
 
        list_for_each_entry(p, &br->port_list, list) {
                if (ether_addr_equal(p->designated_bridge.addr, oldaddr))