serial: 8250_ni: use serial_port_in()/serial_port_out() helpers
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 21 Mar 2025 18:20:16 +0000 (20:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Apr 2025 14:51:20 +0000 (16:51 +0200)
There are serial_port_in()/serial_port_out() helpers to be used
instead of direct p->serial_in()/p->serial_out().

Use them in various 8250 drivers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>
Reviewed-by: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>
Link: https://lore.kernel.org/r/20250321182119.454507-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_ni.c

index 8bb8bb7bb4f2c857d7ce9c4531d20ba313fd164c..15bee1b7dc2a30cd96e7a6e46335d5e3cc965d17 100644 (file)
@@ -90,10 +90,10 @@ static int ni16550_disable_transceivers(struct uart_port *port)
 {
        u8 pcr;
 
-       pcr = port->serial_in(port, NI16550_PCR_OFFSET);
+       pcr = serial_port_in(port, NI16550_PCR_OFFSET);
        pcr &= ~NI16550_PCR_TXVR_ENABLE_BIT;
        dev_dbg(port->dev, "disable transceivers: write pcr: 0x%02x\n", pcr);
-       port->serial_out(port, NI16550_PCR_OFFSET, pcr);
+       serial_port_out(port, NI16550_PCR_OFFSET, pcr);
 
        return 0;
 }
@@ -105,7 +105,7 @@ static int ni16550_rs485_config(struct uart_port *port,
        struct uart_8250_port *up = container_of(port, struct uart_8250_port, port);
        u8 pcr;
 
-       pcr = serial_in(up, NI16550_PCR_OFFSET);
+       pcr = serial_port_in(port, NI16550_PCR_OFFSET);
        pcr &= ~NI16550_PCR_WIRE_MODE_MASK;
 
        if ((rs485->flags & SER_RS485_MODE_RS422) ||
@@ -120,7 +120,7 @@ static int ni16550_rs485_config(struct uart_port *port,
        }
 
        dev_dbg(port->dev, "config rs485: write pcr: 0x%02x, acr: %02x\n", pcr, up->acr);
-       serial_out(up, NI16550_PCR_OFFSET, pcr);
+       serial_port_out(port, NI16550_PCR_OFFSET, pcr);
        serial_icr_write(up, UART_ACR, up->acr);
 
        return 0;