media: sun4i_csi: Implement link validate for sun4i_csi subdev
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 18 Jun 2024 23:46:16 +0000 (02:46 +0300)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 26 Aug 2024 13:36:14 +0000 (16:36 +0300)
The sun4i_csi driver doesn't implement link validation for the subdev it
registers, leaving the link between the subdev and its source
unvalidated. Fix it, using the v4l2_subdev_link_validate() helper.

Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver")
Cc: stable@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c

index 097a3a08ef7d1ffa4ee2f8f5fc6693b993ac3e97..dbb26c7b2f8d7af9c2cfb0abc664cb861a4380dc 100644 (file)
@@ -39,6 +39,10 @@ static const struct media_entity_operations sun4i_csi_video_entity_ops = {
        .link_validate = v4l2_subdev_link_validate,
 };
 
+static const struct media_entity_operations sun4i_csi_subdev_entity_ops = {
+       .link_validate = v4l2_subdev_link_validate,
+};
+
 static int sun4i_csi_notify_bound(struct v4l2_async_notifier *notifier,
                                  struct v4l2_subdev *subdev,
                                  struct v4l2_async_connection *asd)
@@ -214,6 +218,7 @@ static int sun4i_csi_probe(struct platform_device *pdev)
        subdev->internal_ops = &sun4i_csi_subdev_internal_ops;
        subdev->flags = V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;
        subdev->entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;
+       subdev->entity.ops = &sun4i_csi_subdev_entity_ops;
        subdev->owner = THIS_MODULE;
        snprintf(subdev->name, sizeof(subdev->name), "sun4i-csi-0");
        v4l2_set_subdevdata(subdev, csi);