ravb: remove undocumented endianness selection

This patch removes the use of the undocumented BOC bit of the CCC register.

Current documentation for EtherAVB (ravb) describes the offset of what the
driver uses as the BOC bit as reserved and that only a value of 0 should be
written. After some internal investigation with Renesas it remains unclear
why this driver accesses these fields but regardless of what the historical
reasons are the current code is considered incorrect.

Based on work by Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
index 70eeceb7f8aef13e8de2adbafa396ec769e0e78a..bdb051f04b0c99b0254a96980794f163d4264498 100644 (file)
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -216,7 +216,6 @@ enum CCC_BIT {
        CCC_CSEL_HPB    = 0x00010000,
        CCC_CSEL_ETH_TX = 0x00020000,
        CCC_CSEL_GMII_REF = 0x00030000,
-       CCC_BOC         = 0x00100000,   /* Undocumented? */
        CCC_LBME        = 0x01000000,
 };
 

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 4d1f274cded03b0e3a76270de044a39c522ed708..b538cc6fdbb70466b2bb7bc35e740d2af4fc6265 100644 (file)
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -447,12 +447,6 @@ static int ravb_dmac_init(struct net_device *ndev)
        ravb_ring_format(ndev, RAVB_BE);
        ravb_ring_format(ndev, RAVB_NC);
 
-#if defined(__LITTLE_ENDIAN)
-       ravb_modify(ndev, CCC, CCC_BOC, 0);
-#else
-       ravb_modify(ndev, CCC, CCC_BOC, CCC_BOC);
-#endif
-
        /* Set AVB RX */
        ravb_write(ndev,
                   RCR_EFFS | RCR_ENCF | RCR_ETS0 | RCR_ESF | 0x18000000, RCR);