i2c: imx: Switch to RUNTIME_PM_OPS()
authorFabio Estevam <festevam@denx.de>
Wed, 7 Aug 2024 18:14:56 +0000 (15:14 -0300)
committerAndi Shyti <andi.shyti@kernel.org>
Mon, 9 Sep 2024 22:33:55 +0000 (00:33 +0200)
Replace SET_RUNTIME_PM_OPS() with its modern RUNTIME_PM_OPS()
alternative.

The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the
compiler to evaluate if the runtime suspend/resume() functions
are used at build time or are simply dead code.

This allows removing the __maybe_unused notation from the runtime
suspend/resume() functions.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-imx.c

index 3842e527116b799b02860a8807c44d49b5c72375..d68b575e5d18db61aaa41d41dccdf30459374c71 100644 (file)
@@ -1549,7 +1549,7 @@ static void i2c_imx_remove(struct platform_device *pdev)
        pm_runtime_disable(&pdev->dev);
 }
 
-static int __maybe_unused i2c_imx_runtime_suspend(struct device *dev)
+static int i2c_imx_runtime_suspend(struct device *dev)
 {
        struct imx_i2c_struct *i2c_imx = dev_get_drvdata(dev);
 
@@ -1558,7 +1558,7 @@ static int __maybe_unused i2c_imx_runtime_suspend(struct device *dev)
        return 0;
 }
 
-static int __maybe_unused i2c_imx_runtime_resume(struct device *dev)
+static int i2c_imx_runtime_resume(struct device *dev)
 {
        struct imx_i2c_struct *i2c_imx = dev_get_drvdata(dev);
        int ret;
@@ -1571,8 +1571,7 @@ static int __maybe_unused i2c_imx_runtime_resume(struct device *dev)
 }
 
 static const struct dev_pm_ops i2c_imx_pm_ops = {
-       SET_RUNTIME_PM_OPS(i2c_imx_runtime_suspend,
-                          i2c_imx_runtime_resume, NULL)
+       RUNTIME_PM_OPS(i2c_imx_runtime_suspend, i2c_imx_runtime_resume, NULL)
 };
 
 static struct platform_driver i2c_imx_driver = {
@@ -1580,7 +1579,7 @@ static struct platform_driver i2c_imx_driver = {
        .remove_new = i2c_imx_remove,
        .driver = {
                .name = DRIVER_NAME,
-               .pm = &i2c_imx_pm_ops,
+               .pm = pm_ptr(&i2c_imx_pm_ops),
                .of_match_table = i2c_imx_dt_ids,
                .acpi_match_table = i2c_imx_acpi_ids,
        },