net: hns3: Use ARRAY_SIZE() to improve readability
authorZhang Zekun <zhangzekun11@huawei.com>
Sun, 18 Aug 2024 05:25:18 +0000 (13:25 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Aug 2024 22:18:21 +0000 (15:18 -0700)
There is a helper function ARRAY_SIZE() to help calculating the
u32 array size, and we don't need to do it mannually. So, let's
use ARRAY_SIZE() to calculate the array size, and improve the code
readability.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
Reviewed-by: Jijie Shao<shaojijie@huawei.com>
Link: https://patch.msgid.link/20240818052518.45489-1-zhangzekun11@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_regs.c

index 65b9dcd3813756f9d9d64aeac2c560a669765b5d..6db415d8b9176cfb2b480518991fa2f14f097551 100644 (file)
@@ -134,17 +134,17 @@ void hclgevf_get_regs(struct hnae3_handle *handle, u32 *version,
        reg += hclgevf_reg_get_header(reg);
 
        /* fetching per-VF registers values from VF PCIe register space */
-       reg_um = sizeof(cmdq_reg_addr_list) / sizeof(u32);
+       reg_um = ARRAY_SIZE(cmdq_reg_addr_list);
        reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_CMDQ, reg_um, reg);
        for (i = 0; i < reg_um; i++)
                *reg++ = hclgevf_read_dev(&hdev->hw, cmdq_reg_addr_list[i]);
 
-       reg_um = sizeof(common_reg_addr_list) / sizeof(u32);
+       reg_um = ARRAY_SIZE(common_reg_addr_list);
        reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_COMMON, reg_um, reg);
        for (i = 0; i < reg_um; i++)
                *reg++ = hclgevf_read_dev(&hdev->hw, common_reg_addr_list[i]);
 
-       reg_um = sizeof(ring_reg_addr_list) / sizeof(u32);
+       reg_um = ARRAY_SIZE(ring_reg_addr_list);
        for (j = 0; j < hdev->num_tqps; j++) {
                reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_RING, reg_um, reg);
                for (i = 0; i < reg_um; i++)
@@ -153,7 +153,7 @@ void hclgevf_get_regs(struct hnae3_handle *handle, u32 *version,
                                                  HCLGEVF_RING_REG_OFFSET * j);
        }
 
-       reg_um = sizeof(tqp_intr_reg_addr_list) / sizeof(u32);
+       reg_um = ARRAY_SIZE(tqp_intr_reg_addr_list);
        for (j = 0; j < hdev->num_msi_used - 1; j++) {
                reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_TQP_INTR, reg_um, reg);
                for (i = 0; i < reg_um; i++)