media: xbox_remote: xbox_remote_initialize() cannot fail

It cannot fail. Make it void.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/rc/xbox_remote.c b/drivers/media/rc/xbox_remote.c
index 7424b2031152c561b265acc43f43022c68c5cc4f..a1572381d0971a7776638a1728009c4be48c5a5b 100644 (file)
--- a/drivers/media/rc/xbox_remote.c
+++ b/drivers/media/rc/xbox_remote.c
@@ -163,8 +163,8 @@ static void xbox_remote_rc_init(struct xbox_remote *xbox_remote)
        rdev->dev.parent = &xbox_remote->interface->dev;
 }
 
-static int xbox_remote_initialize(struct xbox_remote *xbox_remote,
-                                 struct usb_endpoint_descriptor *endpoint_in)
+static void xbox_remote_initialize(struct xbox_remote *xbox_remote,
+                                  struct usb_endpoint_descriptor *endpoint_in)
 {
        struct usb_device *udev = xbox_remote->udev;
        int pipe, maxp;
@@ -177,8 +177,6 @@ static int xbox_remote_initialize(struct xbox_remote *xbox_remote,
        usb_fill_int_urb(xbox_remote->irq_urb, udev, pipe, xbox_remote->inbuf,
                         maxp, xbox_remote_irq_in, xbox_remote,
                         endpoint_in->bInterval);
-
-       return 0;
 }
 
 /*
@@ -249,9 +247,7 @@ static int xbox_remote_probe(struct usb_interface *interface,
        xbox_remote_rc_init(xbox_remote);
 
        /* Device Hardware Initialization */
-       err = xbox_remote_initialize(xbox_remote, endpoint_in);
-       if (err)
-               goto exit_kill_urbs;
+       xbox_remote_initialize(xbox_remote, endpoint_in);
 
        /* Set up and register rc device */
        err = rc_register_device(xbox_remote->rdev);