i2c: omap: switch to NOIRQ_SYSTEM_SLEEP_PM_OPS() and RUNTIME_PM_OPS()
authorThomas Richard <thomas.richard@bootlin.com>
Thu, 13 Jun 2024 13:13:27 +0000 (15:13 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Mon, 8 Jul 2024 22:46:07 +0000 (00:46 +0200)
Replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS() by
NOIRQ_SYSTEM_SLEEP_PM_OPS() and RUNTIME_PM_OPS().
The usage of pm_ptr() and these more recent macros allows the compiler to
see and drop the dead code.
The unnecessary '__maybe_unused' annotations on PM functions can be
removed.

Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-omap.c

index 30a5ea282a8b080eab1a8d99366a1aaa5626b367..410c8b37f768537a8033ea29a6bcfa3e210c5df1 100644 (file)
@@ -1534,7 +1534,7 @@ static void omap_i2c_remove(struct platform_device *pdev)
        pm_runtime_disable(&pdev->dev);
 }
 
-static int __maybe_unused omap_i2c_runtime_suspend(struct device *dev)
+static int omap_i2c_runtime_suspend(struct device *dev)
 {
        struct omap_i2c_dev *omap = dev_get_drvdata(dev);
 
@@ -1560,7 +1560,7 @@ static int __maybe_unused omap_i2c_runtime_suspend(struct device *dev)
        return 0;
 }
 
-static int __maybe_unused omap_i2c_runtime_resume(struct device *dev)
+static int omap_i2c_runtime_resume(struct device *dev)
 {
        struct omap_i2c_dev *omap = dev_get_drvdata(dev);
 
@@ -1575,10 +1575,10 @@ static int __maybe_unused omap_i2c_runtime_resume(struct device *dev)
 }
 
 static const struct dev_pm_ops omap_i2c_pm_ops = {
-       SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
-                                     pm_runtime_force_resume)
-       SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend,
-                          omap_i2c_runtime_resume, NULL)
+       NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+                                 pm_runtime_force_resume)
+       RUNTIME_PM_OPS(omap_i2c_runtime_suspend,
+                      omap_i2c_runtime_resume, NULL)
 };
 
 static struct platform_driver omap_i2c_driver = {
@@ -1586,7 +1586,7 @@ static struct platform_driver omap_i2c_driver = {
        .remove_new     = omap_i2c_remove,
        .driver         = {
                .name   = "omap_i2c",
-               .pm     = &omap_i2c_pm_ops,
+               .pm     = pm_ptr(&omap_i2c_pm_ops),
                .of_match_table = of_match_ptr(omap_i2c_of_match),
        },
 };