selftests: harness: rename __constructor_order for clarification

Now, __constructor_order is boolean; 1 for forward-order systems,
0 for backward-order systems while parsing __LIST_APPEND().

Change it into a bool variable, and rename it for clarification.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
index 71648d2102cbf9fa337426a7b8fa83c45dd3079a..a5a72415e37b063848771e5e8decb6f628b5cb54 100644 (file)
--- a/tools/testing/selftests/kselftest_harness.h
+++ b/tools/testing/selftests/kselftest_harness.h
@@ -818,7 +818,7 @@
                item->prev = item; \
                return; \
        } \
-       if (__constructor_order == _CONSTRUCTOR_ORDER_FORWARD) { \
+       if (__constructor_order_forward) { \
                item->next = NULL; \
                item->prev = head->prev; \
                item->prev->next = item; \
@@ -882,9 +882,7 @@ struct __test_xfail {
        }
 
 static struct __fixture_metadata *__fixture_list = &_fixture_global;
-static int __constructor_order;
-
-#define _CONSTRUCTOR_ORDER_FORWARD   1
+static bool __constructor_order_forward;
 
 static inline void __register_fixture(struct __fixture_metadata *f)
 {
@@ -935,7 +933,7 @@ static inline bool __test_passed(struct __test_metadata *metadata)
  * list so tests are run in source declaration order.
  * https://gcc.gnu.org/onlinedocs/gccint/Initialization.html
  * However, it seems not all toolchains do this correctly, so use
- * __constructor_order to detect which direction is called first
+ * __constructor_order_foward to detect which direction is called first
  * and adjust list building logic to get things running in the right
  * direction.
  */
@@ -1330,7 +1328,7 @@ static int test_harness_run(int argc, char **argv)
 
 static void __attribute__((constructor)) __constructor_order_first(void)
 {
-       __constructor_order = _CONSTRUCTOR_ORDER_FORWARD;
+       __constructor_order_forward = true;
 }
 
 #endif  /* __KSELFTEST_HARNESS_H */