drm/amd/display: add debug print for DCC validation failure
authorAurabindo Pillai <aurabindo.pillai@amd.com>
Tue, 29 Jun 2021 01:41:08 +0000 (21:41 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 23 Jul 2021 14:07:57 +0000 (10:07 -0400)
[Why&How]
Print a debug message when dcc validation fails in the display driver.
Most DCC enablement related errors are from userspace. Adding a debug
print in case of a failure from display driver will aid quicker triage.

Reviewed-by: Harry Wentland <Harry.Wentland@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 36d8d1d5a30f0834cd3b1597587366353957102a..818a8255390302ea383b52bb2a783aafbf12e81c 100644 (file)
@@ -4747,7 +4747,7 @@ fill_gfx9_plane_attributes_from_modifiers(struct amdgpu_device *adev,
                                          const bool force_disable_dcc)
 {
        const uint64_t modifier = afb->base.modifier;
-       int ret;
+       int ret = 0;
 
        fill_gfx9_tiling_info_from_modifier(adev, tiling_info, modifier);
        tiling_info->gfx9.swizzle = modifier_gfx9_swizzle_mode(modifier);
@@ -4765,9 +4765,9 @@ fill_gfx9_plane_attributes_from_modifiers(struct amdgpu_device *adev,
 
        ret = validate_dcc(adev, format, rotation, tiling_info, dcc, address, plane_size);
        if (ret)
-               return ret;
+               drm_dbg_kms(adev_to_drm(adev), "validate_dcc: returned error: %d\n", ret);
 
-       return 0;
+       return ret;
 }
 
 static int