projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6aaceed
)
drm/xe: Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter()
author
Dan Carpenter
<dan.carpenter@linaro.org>
Tue, 15 Jul 2025 22:59:44 +0000
(17:59 -0500)
committer
Rodrigo Vivi
<rodrigo.vivi@intel.com>
Mon, 28 Jul 2025 14:22:22 +0000
(10:22 -0400)
The fwnode_create_software_node() function returns error pointers. It
never returns NULL. Update the checks to match.
Fixes:
f0e53aadd702
("drm/xe: Support for I2C attached MCUs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link:
https://lore.kernel.org/r/65825d00-81ab-4665-af51-4fff6786a250@sabinyo.mountain
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit
2f264d58cc805a3cefc6b98097f90fbc388136ef
)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_i2c.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/gpu/drm/xe/xe_i2c.c
b/drivers/gpu/drm/xe/xe_i2c.c
index db9c0340be5c4083062b20677b873e9ce9630aeb..1f19718db559736cc0d9b67b2db51617d65ae96d 100644
(file)
--- a/
drivers/gpu/drm/xe/xe_i2c.c
+++ b/
drivers/gpu/drm/xe/xe_i2c.c
@@
-96,8
+96,8
@@
static int xe_i2c_register_adapter(struct xe_i2c *i2c)
int ret;
fwnode = fwnode_create_software_node(xe_i2c_adapter_properties, NULL);
- if (
!fwnode
)
- return
-ENOMEM
;
+ if (
IS_ERR(fwnode)
)
+ return
PTR_ERR(fwnode)
;
/*
* Not using platform_device_register_full() here because we don't have