ALSA: amd7930: replace strcpy() with strscpy()
authorSiddarth Gundu <siddarthsgml@gmail.com>
Tue, 20 May 2025 11:30:12 +0000 (17:00 +0530)
committerTakashi Iwai <tiwai@suse.de>
Tue, 20 May 2025 14:07:18 +0000 (16:07 +0200)
strcpy() is deprecated; use strscpy() instead.

Both the destination and source buffer are of fixed length
so strscpy with 2-arguments is used.

No functional changes intended.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Siddarth Gundu <siddarthsgml@gmail.com>
Link: https://patch.msgid.link/20250520113012.70270-1-siddarthsgml@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/sparc/amd7930.c

index 9bdf3db51d629360c727801ad4eaadd172d16935..e73d3b262f57e731d0f7a9ac6d7d18abb43fc28b 100644 (file)
@@ -39,6 +39,7 @@
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/io.h>
+#include <linux/string.h>
 
 #include <sound/core.h>
 #include <sound/pcm.h>
@@ -754,7 +755,7 @@ static int snd_amd7930_pcm(struct snd_amd7930 *amd)
 
        pcm->private_data = amd;
        pcm->info_flags = 0;
-       strcpy(pcm->name, amd->card->shortname);
+       strscpy(pcm->name, amd->card->shortname);
        amd->pcm = pcm;
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_CONTINUOUS,
@@ -874,7 +875,7 @@ static int snd_amd7930_mixer(struct snd_amd7930 *amd)
                return -EINVAL;
 
        card = amd->card;
-       strcpy(card->mixername, card->shortname);
+       strscpy(card->mixername, card->shortname);
 
        for (idx = 0; idx < ARRAY_SIZE(amd7930_controls); idx++) {
                if ((err = snd_ctl_add(card,
@@ -1007,8 +1008,8 @@ static int amd7930_sbus_probe(struct platform_device *op)
        if (err < 0)
                return err;
 
-       strcpy(card->driver, "AMD7930");
-       strcpy(card->shortname, "Sun AMD7930");
+       strscpy(card->driver, "AMD7930");
+       strscpy(card->shortname, "Sun AMD7930");
        sprintf(card->longname, "%s at 0x%02lx:0x%08Lx, irq %d",
                card->shortname,
                rp->flags & 0xffL,