drm/panel-mantix-mlaf057we51: Drop custom DSI write macro
authorJavier Martinez Canillas <javierm@redhat.com>
Sat, 7 Jan 2023 19:18:20 +0000 (20:18 +0100)
committerJavier Martinez Canillas <javierm@redhat.com>
Wed, 11 Jan 2023 17:50:55 +0000 (18:50 +0100)
There is a macro for this already in the <drm/drm_mipi_dsi.h> header, use
that instead and delete the custom DSI write macro defined in the driver.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230107191822.3787147-12-javierm@redhat.com
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c

index 772e3b6acece819c736d499d056b2886c089353b..9243b2ad828d090be2a0856007d377eb85ed3698 100644 (file)
@@ -45,14 +45,6 @@ static inline struct mantix *panel_to_mantix(struct drm_panel *panel)
        return container_of(panel, struct mantix, panel);
 }
 
-#define dsi_generic_write_seq(dsi, seq...) do {                                \
-               static const u8 d[] = { seq };                          \
-               int ret;                                                \
-               ret = mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d));    \
-               if (ret < 0)                                            \
-                       return ret;                                     \
-       } while (0)
-
 static int mantix_init_sequence(struct mantix *ctx)
 {
        struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
@@ -61,18 +53,18 @@ static int mantix_init_sequence(struct mantix *ctx)
        /*
         * Init sequence was supplied by the panel vendor.
         */
-       dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5A);
+       mipi_dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5A);
 
-       dsi_generic_write_seq(dsi, MANTIX_CMD_INT_CANCEL, 0x03);
-       dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5A, 0x03);
-       dsi_generic_write_seq(dsi, 0x80, 0xA9, 0x00);
+       mipi_dsi_generic_write_seq(dsi, MANTIX_CMD_INT_CANCEL, 0x03);
+       mipi_dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5A, 0x03);
+       mipi_dsi_generic_write_seq(dsi, 0x80, 0xA9, 0x00);
 
-       dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5A, 0x09);
-       dsi_generic_write_seq(dsi, 0x80, 0x64, 0x00, 0x64, 0x00, 0x00);
+       mipi_dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5A, 0x09);
+       mipi_dsi_generic_write_seq(dsi, 0x80, 0x64, 0x00, 0x64, 0x00, 0x00);
        msleep(20);
 
-       dsi_generic_write_seq(dsi, MANTIX_CMD_SPI_FINISH, 0xA5);
-       dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x00, 0x2F);
+       mipi_dsi_generic_write_seq(dsi, MANTIX_CMD_SPI_FINISH, 0xA5);
+       mipi_dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x00, 0x2F);
        msleep(20);
 
        dev_dbg(dev, "Panel init sequence done\n");