spi: spi-pci1xxxx: Fix error code in probe
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 6 Jun 2025 09:04:14 +0000 (12:04 +0300)
committerMark Brown <broonie@kernel.org>
Sun, 8 Jun 2025 22:30:05 +0000 (23:30 +0100)
Return the error code if pci_alloc_irq_vectors() fails.  Don't return
success.

Fixes: b4608e944177 ("spi: spi-pci1xxxx: Fix Probe failure with Dual SPI instance with INTx interrupts")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Thangaraj Samynathan <thangaraj.s@microchip.com>
Link: https://patch.msgid.link/aEKvDrUxD19GWi0u@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pci1xxxx.c

index c6489e90b8b9cfb7cbd0c740549dba6b38287096..9112d8a1a0c82bbc8ded3751212da70c313d5e5e 100644 (file)
@@ -765,7 +765,7 @@ static int pci1xxxx_spi_probe(struct pci_dev *pdev, const struct pci_device_id *
                                                           PCI_IRQ_ALL_TYPES);
                        if (num_vector < 0) {
                                dev_err(&pdev->dev, "Error allocating MSI vectors\n");
-                               return ret;
+                               return num_vector;
                        }
 
                        init_completion(&spi_sub_ptr->spi_xfer_done);