perf kwork: Remove unreachable judgments
authorFeng Yang <yangfeng@kylinos.cn>
Fri, 14 Mar 2025 03:10:13 +0000 (11:10 +0800)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 18 Mar 2025 23:55:30 +0000 (16:55 -0700)
When s2[i] = '\0', if s1[i] != '\0', it will be judged by ret,
and if s1[i] = '\0', it will be judegd by !s1[i].
So in reality, s2 [i] will never make a judgment

Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250314031013.94480-1-yangfeng59949@163.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/bpf_skel/kwork_trace.bpf.c

index cbd79bc4b3302d812cf569781b66f64598d62e58..9ce9c8dddc4b495c6695120c3bcbabf380dba8a6 100644 (file)
@@ -80,7 +80,7 @@ static __always_inline int local_strncmp(const char *s1,
 
        for (i = 0; i < sz; i++) {
                ret = (unsigned char)s1[i] - (unsigned char)s2[i];
-               if (ret || !s1[i] || !s2[i])
+               if (ret || !s1[i])
                        break;
        }