KVM: call cache_all_regs() only once during instruction emulation
authorGleb Natapov <gleb@redhat.com>
Tue, 12 Apr 2011 09:36:25 +0000 (12:36 +0300)
committerAvi Kivity <avi@redhat.com>
Sun, 22 May 2011 12:39:54 +0000 (08:39 -0400)
Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/x86.c

index a9a307a754654ebd6079aa9da0180f227f7c32dd..f5f2d3d44577be5e41bba361f16f0f755eab4e68 100644 (file)
@@ -4459,6 +4459,12 @@ static void init_emulate_ctxt(struct kvm_vcpu *vcpu)
        struct decode_cache *c = &vcpu->arch.emulate_ctxt.decode;
        int cs_db, cs_l;
 
+       /*
+        * TODO: fix emulate.c to use guest_read/write_register
+        * instead of direct ->regs accesses, can save hundred cycles
+        * on Intel for instructions that don't read/change RSP, for
+        * for example.
+        */
        cache_all_regs(vcpu);
 
        kvm_x86_ops->get_cs_db_l_bits(vcpu, &cs_db, &cs_l);
@@ -4562,14 +4568,6 @@ int x86_emulate_instruction(struct kvm_vcpu *vcpu,
 
        kvm_clear_exception_queue(vcpu);
 
-       /*
-        * TODO: fix emulate.c to use guest_read/write_register
-        * instead of direct ->regs accesses, can save hundred cycles
-        * on Intel for instructions that don't read/change RSP, for
-        * for example.
-        */
-       cache_all_regs(vcpu);
-
        if (!(emulation_type & EMULTYPE_NO_DECODE)) {
                init_emulate_ctxt(vcpu);
                vcpu->arch.emulate_ctxt.interruptibility = 0;