wifi: ath9k: cleanup ath_txq_skb_done()

Since 'txq' argument of 'ath_txq_skb_done()' is actually
(mis|un)used, convert the former to local variable and
adjust all related users. Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Link: https://patch.msgid.link/20241209155027.636400-1-dmantipov@yandex.ru
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>

diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 0a24439dd30d7274e860db1c23d55f465087533e..f41f03f55b07fd365e760c0cf94679f4a8166734 100644 (file)
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -208,10 +208,10 @@ static void ath_set_rates(struct ieee80211_vif *vif, struct ieee80211_sta *sta,
                                       ARRAY_SIZE(bf->rates));
 }
 
-static void ath_txq_skb_done(struct ath_softc *sc, struct ath_txq *txq,
-                            struct sk_buff *skb)
+static void ath_txq_skb_done(struct ath_softc *sc, struct sk_buff *skb)
 {
        struct ath_frame_info *fi = get_frame_info(skb);
+       struct ath_txq *txq;
        int q = fi->txq;
 
        if (q < 0)
@@ -294,7 +294,7 @@ static void ath_tx_flush_tid(struct ath_softc *sc, struct ath_atx_tid *tid)
                fi = get_frame_info(skb);
                bf = fi->bf;
                if (!bf) {
-                       ath_txq_skb_done(sc, txq, skb);
+                       ath_txq_skb_done(sc, skb);
                        ieee80211_free_txskb(sc->hw, skb);
                        continue;
                }
@@ -962,7 +962,7 @@ ath_tx_get_tid_subframe(struct ath_softc *sc, struct ath_txq *txq,
                        bf->bf_state.stale = false;
 
                if (!bf) {
-                       ath_txq_skb_done(sc, txq, skb);
+                       ath_txq_skb_done(sc, skb);
                        ieee80211_free_txskb(sc->hw, skb);
                        continue;
                }
@@ -2379,7 +2379,7 @@ int ath_tx_start(struct ieee80211_hw *hw, struct sk_buff *skb,
 
        bf = ath_tx_setup_buffer(sc, txq, tid, skb);
        if (!bf) {
-               ath_txq_skb_done(sc, txq, skb);
+               ath_txq_skb_done(sc, skb);
                if (txctl->paprd)
                        dev_kfree_skb_any(skb);
                else
@@ -2514,7 +2514,7 @@ static void ath_tx_complete(struct ath_softc *sc, struct sk_buff *skb,
        }
        spin_unlock_irqrestore(&sc->sc_pm_lock, flags);
 
-       ath_txq_skb_done(sc, txq, skb);
+       ath_txq_skb_done(sc, skb);
        tx_info->status.status_driver_data[0] = sta;
        __skb_queue_tail(&txq->complete_q, skb);
 }