staging: rtl8723bs: remove redundant null check on pregpriv
authorWen Yang <wen.yang99@zte.com.cn>
Sat, 24 Nov 2018 11:22:19 +0000 (11:22 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 26 Nov 2018 19:59:05 +0000 (20:59 +0100)
The null check on &padapter->registrypriv is redundant since registrypriv
is a struct inside padapter and can never be null, so the check is always
true.  we may remove it.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: devel@driverdev.osuosl.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

index 28bfdbdc6e76aa1bcc4aecbb1b07c7a8f3483f32..59810f6e7412fbefddb7c58db0089e4070905dac 100644 (file)
@@ -2975,7 +2975,7 @@ static int rtw_dbg_port(struct net_device *dev,
                                        struct registry_priv *pregpriv = &padapter->registrypriv;
                                        /*  0: disable, bit(0):enable 2.4g, bit(1):enable 5g, 0x3: enable both 2.4g and 5g */
                                        /* default is set to enable 2.4GHZ for IOT issue with bufflao's AP at 5GHZ */
-                                       if (pregpriv && (extra_arg == 0 || extra_arg == 1|| extra_arg == 2 || extra_arg == 3)) {
+                                       if (extra_arg == 0 || extra_arg == 1 || extra_arg == 2 || extra_arg == 3) {
                                                pregpriv->rx_stbc = extra_arg;
                                                DBG_871X("set rx_stbc =%d\n", pregpriv->rx_stbc);
                                        } else
@@ -2987,7 +2987,7 @@ static int rtw_dbg_port(struct net_device *dev,
                                {
                                        struct registry_priv *pregpriv = &padapter->registrypriv;
                                        /*  0: disable, 0x1:enable (but wifi_spec should be 0), 0x2: force enable (don't care wifi_spec) */
-                                       if (pregpriv && extra_arg < 3) {
+                                       if (extra_arg < 3) {
                                                pregpriv->ampdu_enable = extra_arg;
                                                DBG_871X("set ampdu_enable =%d\n", pregpriv->ampdu_enable);
                                        } else