media: ti: cal: fix useless variable init

'ret' is initialized needlessly in cal_legacy_try_fmt_vid_cap(). We can
also move the variable to the for block, which is the only place where
it is used.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/platform/ti/cal/cal-video.c b/drivers/media/platform/ti/cal/cal-video.c
index 776da0cfcdbe284de54cc9be204d06ee8c489b28..21e3d0aabf706d7e108ed31c12db81564d001431 100644 (file)
--- a/drivers/media/platform/ti/cal/cal-video.c
+++ b/drivers/media/platform/ti/cal/cal-video.c
@@ -191,7 +191,7 @@ static int cal_legacy_try_fmt_vid_cap(struct file *file, void *priv,
        struct cal_ctx *ctx = video_drvdata(file);
        const struct cal_format_info *fmtinfo;
        struct v4l2_subdev_frame_size_enum fse;
-       int ret, found;
+       int found;
 
        fmtinfo = find_format_by_pix(ctx, f->fmt.pix.pixelformat);
        if (!fmtinfo) {
@@ -206,12 +206,13 @@ static int cal_legacy_try_fmt_vid_cap(struct file *file, void *priv,
        f->fmt.pix.field = ctx->v_fmt.fmt.pix.field;
 
        /* check for/find a valid width/height */
-       ret = 0;
        found = false;
        fse.pad = 0;
        fse.code = fmtinfo->code;
        fse.which = V4L2_SUBDEV_FORMAT_ACTIVE;
        for (fse.index = 0; ; fse.index++) {
+               int ret;
+
                ret = v4l2_subdev_call(ctx->phy->source, pad, enum_frame_size,
                                       NULL, &fse);
                if (ret)