scsi: qla2xxx: Remove unused qla82xx_wait_for_state_change()
authorDr. David Alan Gilbert <linux@treblig.org>
Tue, 15 Apr 2025 00:28:00 +0000 (01:28 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 22 Apr 2025 01:49:16 +0000 (21:49 -0400)
qla82xx_wait_for_state_change() was added in 2010 as part of commit
579d12b58abb ("[SCSI] qla2xxx: Added support for quiescence mode for
ISP82xx.")  but has remained unused.

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://lore.kernel.org/r/20250415002803.135909-6-linux@treblig.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_gbl.h
drivers/scsi/qla2xxx/qla_nx.c

index ad76cf8e123d45940564fcc087722006830563c5..73bccd5147917dd5f736d5e9d8c713656df6f6d0 100644 (file)
@@ -865,7 +865,6 @@ extern int qla82xx_rd_32(struct qla_hw_data *, ulong);
 
 /* ISP 8021 IDC */
 extern void qla82xx_clear_drv_active(struct qla_hw_data *);
-extern uint32_t  qla82xx_wait_for_state_change(scsi_qla_host_t *, uint32_t);
 extern int qla82xx_idc_lock(struct qla_hw_data *);
 extern void qla82xx_idc_unlock(struct qla_hw_data *);
 extern int qla82xx_device_state_handler(scsi_qla_host_t *);
index 1da954f446f6c0d4c26f1b4f54fa81f43ee4f09f..78725bda3714f8b49246996dfeede87140f7470f 100644 (file)
@@ -2915,32 +2915,6 @@ qla82xx_need_qsnt_handler(scsi_qla_host_t *vha)
        }
 }
 
-/*
-* qla82xx_wait_for_state_change
-*    Wait for device state to change from given current state
-*
-* Note:
-*     IDC lock must not be held upon entry
-*
-* Return:
-*    Changed device state.
-*/
-uint32_t
-qla82xx_wait_for_state_change(scsi_qla_host_t *vha, uint32_t curr_state)
-{
-       struct qla_hw_data *ha = vha->hw;
-       uint32_t dev_state;
-
-       do {
-               msleep(1000);
-               qla82xx_idc_lock(ha);
-               dev_state = qla82xx_rd_32(ha, QLA82XX_CRB_DEV_STATE);
-               qla82xx_idc_unlock(ha);
-       } while (dev_state == curr_state);
-
-       return dev_state;
-}
-
 void
 qla8xxx_dev_failed_handler(scsi_qla_host_t *vha)
 {