bus: brcmstb_gisb: use dev_groups to register attribute groups
authorOvidiu Panait <ovidiu.panait.oss@gmail.com>
Mon, 24 Feb 2025 19:37:30 +0000 (21:37 +0200)
committerFlorian Fainelli <florian.fainelli@broadcom.com>
Mon, 7 Apr 2025 17:35:43 +0000 (10:35 -0700)
Instead of manually adding attribute groups, set dev_groups pointer to
have the driver core do it.

Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Link: https://lore.kernel.org/r/20250224193730.2698894-1-ovidiu.panait.oss@gmail.com
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
drivers/bus/brcmstb_gisb.c

index ee29162da4ee8f430164bc80d3975bf09fbdc254..91ef99c42344c50ce7c6f3d75ec15883bc4a5bed 100644 (file)
@@ -395,10 +395,7 @@ static struct attribute *gisb_arb_sysfs_attrs[] = {
        &dev_attr_gisb_arb_timeout.attr,
        NULL,
 };
-
-static struct attribute_group gisb_arb_sysfs_attr_group = {
-       .attrs = gisb_arb_sysfs_attrs,
-};
+ATTRIBUTE_GROUPS(gisb_arb_sysfs);
 
 static const struct of_device_id brcmstb_gisb_arb_of_match[] = {
        { .compatible = "brcm,gisb-arb",         .data = gisb_offsets_bcm7445 },
@@ -490,10 +487,6 @@ static int __init brcmstb_gisb_arb_probe(struct platform_device *pdev)
                }
        }
 
-       err = sysfs_create_group(&pdev->dev.kobj, &gisb_arb_sysfs_attr_group);
-       if (err)
-               return err;
-
        platform_set_drvdata(pdev, gdev);
 
        list_add_tail(&gdev->next, &brcmstb_gisb_arb_device_list);
@@ -550,6 +543,7 @@ static struct platform_driver brcmstb_gisb_arb_driver = {
                .name   = "brcm-gisb-arb",
                .of_match_table = brcmstb_gisb_arb_of_match,
                .pm     = &brcmstb_gisb_arb_pm_ops,
+               .dev_groups = gisb_arb_sysfs_groups,
        },
 };