irqdomain: Introduce irq_domain_instantiate()

The existing irq_domain_add_*() functions used to instantiate an IRQ
domain are wrappers built on top of __irq_domain_add() and describe the
domain properties using a bunch of parameters.

Adding more parameters and wrappers to hide new parameters in the
existing code lead to more and more code without any relevant value and
without any flexibility.

Introduce irq_domain_instantiate() where the interrupt domain properties
are given using a irq_domain_info structure instead of the bunch of
parameters to allow flexibility and easy evolution.

irq_domain_instantiate() performs the same operation as the one done by
__irq_domain_add(). For compatibility reason with existing code, keep
__irq_domain_add() but convert it to irq_domain_instantiate().

[ tglx: Fixed up struct initializer coding style ]

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240614173232.1184015-3-herve.codina@bootlin.com

diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
index 21ecf582a0fe4ac070db364192be12ce9b1f253c..ab8939c8724d8ec647b1a916eccf29a7bdae7f87 100644 (file)
--- a/include/linux/irqdomain.h
+++ b/include/linux/irqdomain.h
@@ -257,6 +257,27 @@ static inline struct fwnode_handle *irq_domain_alloc_fwnode(phys_addr_t *pa)
 }
 
 void irq_domain_free_fwnode(struct fwnode_handle *fwnode);
+/**
+ * struct irq_domain_info - Domain information structure
+ * @fwnode:            firmware node for the interrupt controller
+ * @size:              Size of linear map; 0 for radix mapping only
+ * @hwirq_max:         Maximum number of interrupts supported by controller
+ * @direct_max:                Maximum value of direct maps;
+ *                     Use ~0 for no limit; 0 for no direct mapping
+ * @ops:               Domain operation callbacks
+ * @host_data:         Controller private data pointer
+ */
+struct irq_domain_info {
+       struct fwnode_handle                    *fwnode;
+       unsigned int                            size;
+       irq_hw_number_t                         hwirq_max;
+       int                                     direct_max;
+       const struct irq_domain_ops             *ops;
+       void                                    *host_data;
+};
+
+struct irq_domain *irq_domain_instantiate(const struct irq_domain_info *info);
+
 struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, unsigned int size,
                                    irq_hw_number_t hwirq_max, int direct_max,
                                    const struct irq_domain_ops *ops,

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 40b631bd28363108f2039bec23c1f7ea17b39dd6..111052f363ea0d1bf662b714944c0ee17c71fe08 100644 (file)
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -247,6 +247,27 @@ static void irq_domain_free(struct irq_domain *domain)
        kfree(domain);
 }
 
+/**
+ * irq_domain_instantiate() - Instantiate a new irq domain data structure
+ * @info: Domain information pointer pointing to the information for this domain
+ *
+ * Return: A pointer to the instantiated irq domain or an ERR_PTR value.
+ */
+struct irq_domain *irq_domain_instantiate(const struct irq_domain_info *info)
+{
+       struct irq_domain *domain;
+
+       domain = __irq_domain_create(info->fwnode, info->size, info->hwirq_max,
+                                    info->direct_max, info->ops, info->host_data);
+       if (!domain)
+               return ERR_PTR(-ENOMEM);
+
+       __irq_domain_publish(domain);
+
+       return domain;
+}
+EXPORT_SYMBOL_GPL(irq_domain_instantiate);
+
 /**
  * __irq_domain_add() - Allocate a new irq_domain data structure
  * @fwnode: firmware node for the interrupt controller
@@ -265,14 +286,18 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, unsigned int s
                                    const struct irq_domain_ops *ops,
                                    void *host_data)
 {
-       struct irq_domain *domain;
-
-       domain = __irq_domain_create(fwnode, size, hwirq_max, direct_max,
-                                    ops, host_data);
-       if (domain)
-               __irq_domain_publish(domain);
+       struct irq_domain_info info = {
+               .fwnode         = fwnode,
+               .size           = size,
+               .hwirq_max      = hwirq_max,
+               .direct_max     = direct_max,
+               .ops            = ops,
+               .host_data      = host_data,
+       };
+       struct irq_domain *d;
 
-       return domain;
+       d = irq_domain_instantiate(&info);
+       return IS_ERR(d) ? NULL : d;
 }
 EXPORT_SYMBOL_GPL(__irq_domain_add);