net: prefix devmem specific helpers
authorPavel Begunkov <asml.silence@gmail.com>
Tue, 4 Feb 2025 21:56:13 +0000 (13:56 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 7 Feb 2025 00:27:30 +0000 (16:27 -0800)
Add prefixes to all helpers that are specific to devmem TCP, i.e.
net_iov_binding[_id].

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: David Wei <dw@davidwei.uk>
Link: https://patch.msgid.link/20250204215622.695511-3-dw@davidwei.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/devmem.c
net/core/devmem.h
net/ipv4/tcp.c

index 3bba3f018df0349e125803a3bc4fed781bea46bc..66cd1ab9224fb86951c55c9acd26e4c8f41ddc47 100644 (file)
@@ -94,7 +94,7 @@ net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding)
 
 void net_devmem_free_dmabuf(struct net_iov *niov)
 {
-       struct net_devmem_dmabuf_binding *binding = net_iov_binding(niov);
+       struct net_devmem_dmabuf_binding *binding = net_devmem_iov_binding(niov);
        unsigned long dma_addr = net_devmem_get_dma_addr(niov);
 
        if (WARN_ON(!gen_pool_has_addr(binding->chunk_pool, dma_addr,
index 76099ef9c482f52ac3d72e7e31ce16948471b08e..99782ddeca40859e9107620c22b3150ad3d10a85 100644 (file)
@@ -86,11 +86,16 @@ static inline unsigned int net_iov_idx(const struct net_iov *niov)
 }
 
 static inline struct net_devmem_dmabuf_binding *
-net_iov_binding(const struct net_iov *niov)
+net_devmem_iov_binding(const struct net_iov *niov)
 {
        return net_iov_owner(niov)->binding;
 }
 
+static inline u32 net_devmem_iov_binding_id(const struct net_iov *niov)
+{
+       return net_devmem_iov_binding(niov)->id;
+}
+
 static inline unsigned long net_iov_virtual_addr(const struct net_iov *niov)
 {
        struct dmabuf_genpool_chunk_owner *owner = net_iov_owner(niov);
@@ -99,11 +104,6 @@ static inline unsigned long net_iov_virtual_addr(const struct net_iov *niov)
               ((unsigned long)net_iov_idx(niov) << PAGE_SHIFT);
 }
 
-static inline u32 net_iov_binding_id(const struct net_iov *niov)
-{
-       return net_iov_owner(niov)->binding->id;
-}
-
 static inline void
 net_devmem_dmabuf_binding_get(struct net_devmem_dmabuf_binding *binding)
 {
@@ -171,7 +171,7 @@ static inline unsigned long net_iov_virtual_addr(const struct net_iov *niov)
        return 0;
 }
 
-static inline u32 net_iov_binding_id(const struct net_iov *niov)
+static inline u32 net_devmem_iov_binding_id(const struct net_iov *niov)
 {
        return 0;
 }
index 0d704bda6c416bd722223eb19bec5667df4e7bb7..b872de9a8271b2ef18bcc2c3db0895898b6ec3f8 100644 (file)
@@ -2494,7 +2494,7 @@ static int tcp_recvmsg_dmabuf(struct sock *sk, const struct sk_buff *skb,
 
                                /* Will perform the exchange later */
                                dmabuf_cmsg.frag_token = tcp_xa_pool.tokens[tcp_xa_pool.idx];
-                               dmabuf_cmsg.dmabuf_id = net_iov_binding_id(niov);
+                               dmabuf_cmsg.dmabuf_id = net_devmem_iov_binding_id(niov);
 
                                offset += copy;
                                remaining_len -= copy;