leds: backlight trigger: Move blank-state handling into helper
authorThomas Zimmermann <tzimmermann@suse.de>
Fri, 21 Mar 2025 09:54:02 +0000 (10:54 +0100)
committerLee Jones <lee@kernel.org>
Thu, 10 Apr 2025 09:39:12 +0000 (10:39 +0100)
Move the handling of blank-state updates into a separate helper,
so that is can be called without the fbdev event. No functional
changes.

v2:
- rename helper to avoid renaming in a later patch (Lee)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Simona Vetter <simona.vetter@ffwll.ch>
Link: https://lore.kernel.org/r/20250321095517.313713-10-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/trigger/ledtrig-backlight.c

index 487577d22cfc651fed0127a4707b680ef8a5e1d7..8e66d55a6c824567053049665e63f7a7655ba727 100644 (file)
@@ -25,12 +25,28 @@ struct bl_trig_notifier {
        unsigned invert;
 };
 
+static void ledtrig_backlight_notify_blank(struct bl_trig_notifier *n, int new_status)
+{
+       struct led_classdev *led = n->led;
+
+       if (new_status == n->old_status)
+               return;
+
+       if ((n->old_status == UNBLANK) ^ n->invert) {
+               n->brightness = led->brightness;
+               led_set_brightness_nosleep(led, LED_OFF);
+       } else {
+               led_set_brightness_nosleep(led, n->brightness);
+       }
+
+       n->old_status = new_status;
+}
+
 static int fb_notifier_callback(struct notifier_block *p,
                                unsigned long event, void *data)
 {
        struct bl_trig_notifier *n = container_of(p,
                                        struct bl_trig_notifier, notifier);
-       struct led_classdev *led = n->led;
        struct fb_event *fb_event = data;
        int *blank;
        int new_status;
@@ -42,17 +58,7 @@ static int fb_notifier_callback(struct notifier_block *p,
        blank = fb_event->data;
        new_status = *blank ? BLANK : UNBLANK;
 
-       if (new_status == n->old_status)
-               return 0;
-
-       if ((n->old_status == UNBLANK) ^ n->invert) {
-               n->brightness = led->brightness;
-               led_set_brightness_nosleep(led, LED_OFF);
-       } else {
-               led_set_brightness_nosleep(led, n->brightness);
-       }
-
-       n->old_status = new_status;
+       ledtrig_backlight_notify_blank(n, new_status);
 
        return 0;
 }