usb: cdnsp: Fix issue with CV Bad Descriptor test

The SSP2 controller has extra endpoint state preserve bit (ESP) which
setting causes that endpoint state will be preserved during
Halt Endpoint command. It is used only for EP0.
Without this bit the Command Verifier "TD 9.10 Bad Descriptor Test"
failed.
Setting this bit doesn't have any impact for SSP controller.

Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
Cc: stable <stable@kernel.org>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Link: https://lore.kernel.org/r/PH7PR07MB95382CCD50549DABAEFD6156DD7CA@PH7PR07MB9538.namprd07.prod.outlook.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/cdns3/cdnsp-debug.h b/drivers/usb/cdns3/cdnsp-debug.h
index cd138acdcce16500e0b875ca31c9148618e5272a..86860686d8363ee3a50ee4395ab2eb6ccdc8a09e 100644 (file)
--- a/drivers/usb/cdns3/cdnsp-debug.h
+++ b/drivers/usb/cdns3/cdnsp-debug.h
@@ -327,12 +327,13 @@ static inline const char *cdnsp_decode_trb(char *str, size_t size, u32 field0,
        case TRB_RESET_EP:
        case TRB_HALT_ENDPOINT:
                ret = scnprintf(str, size,
-                               "%s: ep%d%s(%d) ctx %08x%08x slot %ld flags %c",
+                               "%s: ep%d%s(%d) ctx %08x%08x slot %ld flags %c %c",
                                cdnsp_trb_type_string(type),
                                ep_num, ep_id % 2 ? "out" : "in",
                                TRB_TO_EP_INDEX(field3), field1, field0,
                                TRB_TO_SLOT_ID(field3),
-                               field3 & TRB_CYCLE ? 'C' : 'c');
+                               field3 & TRB_CYCLE ? 'C' : 'c',
+                               field3 & TRB_ESP ? 'P' : 'p');
                break;
        case TRB_STOP_RING:
                ret = scnprintf(str, size,

diff --git a/drivers/usb/cdns3/cdnsp-ep0.c b/drivers/usb/cdns3/cdnsp-ep0.c
index f317d3c84781082d00d27f13481a5f759e7d1515..5cd9b898ce971fb7a794a0fa4cb397d4e299725b 100644 (file)
--- a/drivers/usb/cdns3/cdnsp-ep0.c
+++ b/drivers/usb/cdns3/cdnsp-ep0.c
@@ -414,6 +414,7 @@ static int cdnsp_ep0_std_request(struct cdnsp_device *pdev,
 void cdnsp_setup_analyze(struct cdnsp_device *pdev)
 {
        struct usb_ctrlrequest *ctrl = &pdev->setup;
+       struct cdnsp_ep *pep;
        int ret = -EINVAL;
        u16 len;
 
@@ -427,10 +428,21 @@ void cdnsp_setup_analyze(struct cdnsp_device *pdev)
                goto out;
        }
 
+       pep = &pdev->eps[0];
+
        /* Restore the ep0 to Stopped/Running state. */
-       if (pdev->eps[0].ep_state & EP_HALTED) {
-               trace_cdnsp_ep0_halted("Restore to normal state");
-               cdnsp_halt_endpoint(pdev, &pdev->eps[0], 0);
+       if (pep->ep_state & EP_HALTED) {
+               if (GET_EP_CTX_STATE(pep->out_ctx) == EP_STATE_HALTED)
+                       cdnsp_halt_endpoint(pdev, pep, 0);
+
+               /*
+                * Halt Endpoint Command for SSP2 for ep0 preserve current
+                * endpoint state and driver has to synchronize the
+                * software endpoint state with endpoint output context
+                * state.
+                */
+               pep->ep_state &= ~EP_HALTED;
+               pep->ep_state |= EP_STOPPED;
        }
 
        /*

diff --git a/drivers/usb/cdns3/cdnsp-gadget.h b/drivers/usb/cdns3/cdnsp-gadget.h
index 2afa3e558f85ca264511014de7698c2d4ca7dbdb..a91cca509db0806e6b04acae2e5dc012d4dfc147 100644 (file)
--- a/drivers/usb/cdns3/cdnsp-gadget.h
+++ b/drivers/usb/cdns3/cdnsp-gadget.h
@@ -987,6 +987,12 @@ enum cdnsp_setup_dev {
 #define STREAM_ID_FOR_TRB(p)           ((((p)) << 16) & GENMASK(31, 16))
 #define SCT_FOR_TRB(p)                 (((p) << 1) & 0x7)
 
+/*
+ * Halt Endpoint Command TRB field.
+ * The ESP bit only exists in the SSP2 controller.
+ */
+#define TRB_ESP                                BIT(9)
+
 /* Link TRB specific fields. */
 #define TRB_TC                         BIT(1)
 

diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c
index 757fdd918286db5a848b19a4c0f5fbf67a5ac634..0758f171f73ecf1ab1c0b3d0698632f0058eed61 100644 (file)
--- a/drivers/usb/cdns3/cdnsp-ring.c
+++ b/drivers/usb/cdns3/cdnsp-ring.c
@@ -2485,7 +2485,8 @@ void cdnsp_queue_halt_endpoint(struct cdnsp_device *pdev, unsigned int ep_index)
 {
        cdnsp_queue_command(pdev, 0, 0, 0, TRB_TYPE(TRB_HALT_ENDPOINT) |
                            SLOT_ID_FOR_TRB(pdev->slot_id) |
-                           EP_ID_FOR_TRB(ep_index));
+                           EP_ID_FOR_TRB(ep_index) |
+                           (!ep_index ? TRB_ESP : 0));
 }
 
 void cdnsp_force_header_wakeup(struct cdnsp_device *pdev, int intf_num)