drm/bridge: parade-ps8640: Reorg the macros
authorPhilip Chen <philipchen@chromium.org>
Wed, 25 Aug 2021 01:11:55 +0000 (18:11 -0700)
committerDouglas Anderson <dianders@chromium.org>
Thu, 26 Aug 2021 18:06:16 +0000 (11:06 -0700)
Reorg the macros as follows:
(1) Group the registers on the same page together.
(2) Group the register and its bit operation together while indenting
the macros of the bit operation with one space.

Also fix a misnomer for the number of mipi data lanes.

Signed-off-by: Philip Chen <philipchen@chromium.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210824181140.v2.1.I8ead7431357409f2526e5739ec5bc3ddfd242243@changeid
drivers/gpu/drm/bridge/parade-ps8640.c

index 7bd0affa057a59770df67ea86b46e4b2c411736d..685e9c38b2db96f5fa219dd0c079e4037f18092c 100644 (file)
 #include <drm/drm_print.h>
 
 #define PAGE2_GPIO_H           0xa7
-#define PS_GPIO9               BIT(1)
+#define  PS_GPIO9              BIT(1)
 #define PAGE2_I2C_BYPASS       0xea
-#define I2C_BYPASS_EN          0xd0
+#define  I2C_BYPASS_EN         0xd0
 #define PAGE2_MCS_EN           0xf3
-#define MCS_EN                 BIT(0)
+#define  MCS_EN                        BIT(0)
+
 #define PAGE3_SET_ADD          0xfe
-#define VDO_CTL_ADD            0x13
-#define VDO_DIS                        0x18
-#define VDO_EN                 0x1c
-#define DP_NUM_LANES           4
+#define  VDO_CTL_ADD           0x13
+#define  VDO_DIS               0x18
+#define  VDO_EN                        0x1c
+
+#define NUM_MIPI_LANES         4
 
 /*
  * PS8640 uses multiple addresses:
@@ -254,7 +256,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
                          MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
        dsi->format = MIPI_DSI_FMT_RGB888;
-       dsi->lanes = DP_NUM_LANES;
+       dsi->lanes = NUM_MIPI_LANES;
        ret = mipi_dsi_attach(dsi);
        if (ret)
                goto err_dsi_attach;