soc: mediatek: cmdq: Don't log an error when gce-client-reg is not found
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Thu, 29 Feb 2024 19:51:08 +0000 (14:51 -0500)
committerAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tue, 23 Apr 2024 10:16:55 +0000 (12:16 +0200)
Most of the callers to this function do not require CMDQ support, it is
optional, so the missing property shouldn't cause an error message.
However, it could result on degraded performance, so the fact that it's
missing should still be alerted. Furthermore, the callers that do
require CMDQ support already log at the error level when an error is
returned.

Change the log message in this helper to be printed at the warning level
instead.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240229-gce-client-reg-log-dbg-v2-1-4975077173d0@collabora.com
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
drivers/soc/mediatek/mtk-cmdq-helper.c

index d1ca4b21587e020b546f78de16140f4ddbf7044f..046522664dc19c1d065c65ab04fd1af19279d9ca 100644 (file)
@@ -58,7 +58,7 @@ int cmdq_dev_get_client_reg(struct device *dev,
                                               "mediatek,gce-client-reg",
                                               3, idx, &spec);
        if (err < 0) {
-               dev_err(dev,
+               dev_warn(dev,
                        "error %d can't parse gce-client-reg property (%d)",
                        err, idx);