hwmon: (hp-wmi-sensors) Use the WMI bus API when accessing sensors
authorArmin Wolf <W_Armin@gmx.de>
Sun, 16 Feb 2025 19:32:44 +0000 (20:32 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 24 Feb 2025 11:19:12 +0000 (13:19 +0200)
Since the driver already binds to HP_WMI_NUMERIC_SENSOR_GUID, using
wmidev_block_query() allows for faster sensor access.

Acked-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: James Seo <james@equiv.tech>
Reviewed-by: James Seo <james@equiv.tech>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20250216193251.866125-2-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/hwmon/hp-wmi-sensors.c

index d6bdad26feb116ebb53ce0383e90f0f4c4a1f888..03c684ba83bd64592053829b7691fc512d6a74f2 100644 (file)
@@ -1197,7 +1197,7 @@ static int hp_wmi_update_info(struct hp_wmi_sensors *state,
        if (time_after(jiffies, info->last_updated + HZ)) {
                mutex_lock(&state->lock);
 
-               wobj = hp_wmi_get_wobj(HP_WMI_NUMERIC_SENSOR_GUID, instance);
+               wobj = wmidev_block_query(state->wdev, instance);
                if (!wobj) {
                        ret = -EIO;
                        goto out_unlock;
@@ -1745,7 +1745,7 @@ static int init_numeric_sensors(struct hp_wmi_sensors *state,
                return -ENOMEM;
 
        for (i = 0, info = info_arr; i < icount; i++, info++) {
-               wobj = hp_wmi_get_wobj(HP_WMI_NUMERIC_SENSOR_GUID, i);
+               wobj = wmidev_block_query(state->wdev, i);
                if (!wobj)
                        return -EIO;