drm/amdgpu: remove dead code in atom_get_src_int
authorJesse Zhang <jesse.zhang@amd.com>
Wed, 5 Jun 2024 07:44:38 +0000 (15:44 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 14 Jun 2024 19:34:10 +0000 (15:34 -0400)
Since the range of align is 0~7, the expression is: align = (attr >> 3) & 7.
In the case of ATOM_ARG_IMM, the code cannot reach the default case.
So there is no need for "break".

Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Suggested-by: Tim Huang <Tim.Huang@amd.com>
Reviewed-by: Tim Huang <Tim.Huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/atom.c

index d552e013354c956d631f3041b8f8a38a169d05f7..09715b506468df3779423e5bcadd25fbac35b5fa 100644 (file)
@@ -301,7 +301,7 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, uint8_t attr,
                        (*ptr) += 4;
                        if (print)
                                DEBUG("IMM 0x%08X\n", val);
-                       return val;
+                       break;
                case ATOM_SRC_WORD0:
                case ATOM_SRC_WORD8:
                case ATOM_SRC_WORD16:
@@ -309,7 +309,7 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, uint8_t attr,
                        (*ptr) += 2;
                        if (print)
                                DEBUG("IMM 0x%04X\n", val);
-                       return val;
+                       break;
                case ATOM_SRC_BYTE0:
                case ATOM_SRC_BYTE8:
                case ATOM_SRC_BYTE16:
@@ -318,9 +318,9 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, uint8_t attr,
                        (*ptr)++;
                        if (print)
                                DEBUG("IMM 0x%02X\n", val);
-                       return val;
+                       break;
                }
-               break;
+               return val;
        case ATOM_ARG_PLL:
                idx = U8(*ptr);
                (*ptr)++;