ASoC: xilinx: Suppress second error message about reset failure in .remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 5 Jul 2022 09:26:45 +0000 (11:26 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 5 Jul 2022 15:44:31 +0000 (16:44 +0100)
Returning an error value in a platform remove callback results in an error
message being emitted by the platform core, but otherwise it doesn't make
a difference. If ret is != 0, there is already an error message and another
very generic doesn't add any value, so return 0 unconditionally.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220705092645.101343-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/xilinx/xlnx_formatter_pcm.c

index f5ac0aa312d6ed932779bfdf4895e0cb5eb570d2..ff1fe62fea7028eed06a96d22855bbce311917b1 100644 (file)
@@ -703,7 +703,7 @@ static int xlnx_formatter_pcm_remove(struct platform_device *pdev)
                dev_err(&pdev->dev, "audio formatter reset failed\n");
 
        clk_disable_unprepare(adata->axi_clk);
-       return ret;
+       return 0;
 }
 
 static const struct of_device_id xlnx_formatter_pcm_of_match[] = {